Fix reproducibility issue with GPU#781
Fix reproducibility issue with GPU#781HendricksJudy wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
Fixes facebookresearch#752 Add deterministic resizing method to `ResizeLongestSide` class and update relevant scripts and notebooks. * Add `apply_image_deterministic` method to `ResizeLongestSide` class in `segment_anything/utils/transforms.py` to ensure deterministic resizing using `torch.nn.functional.interpolate` with `mode='nearest'`. * Update `notebooks/onnx_model_example.ipynb` to use `apply_image_deterministic` method for resizing images and add a note about the non-reproducibility issue with GPU and potential workaround using CPU. * Update `scripts/amg.py` to use `apply_image_deterministic` method for resizing images. * Add a note in `README.md` about the non-reproducibility issue with GPU and potential workaround using CPU.
|
Hi @HendricksJudy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
…method for resizing images * Add a note about the non-reproducibility issue with GPU and potential workaround using CPU
Fixes #752
Add deterministic resizing method to
ResizeLongestSideclass and update relevant scripts and notebooks.apply_image_deterministicmethod toResizeLongestSideclass insegment_anything/utils/transforms.pyto ensure deterministic resizing usingtorch.nn.functional.interpolatewithmode='nearest'.notebooks/onnx_model_example.ipynbto useapply_image_deterministicmethod for resizing images and add a note about the non-reproducibility issue with GPU and potential workaround using CPU.scripts/amg.pyto useapply_image_deterministicmethod for resizing images.README.mdabout the non-reproducibility issue with GPU and potential workaround using CPU.