Merged
Conversation
gir-bot
added
S: needs-review
Spaces that are scaled on an order of magnitude of 1 should not have the same threshold of a space scaled at an order of magnitude of 100. If they are, this can cause colors to be considered achromatic much earlier if they are scaled small.
facelessuser
force-pushed
the
bugfix/better-achromatic-threshold
branch
from
8745c40 to
d0baaca
Compare
Owner
Author
|
@gir-bot lgtm |
gir-bot
added
S: approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spaces that are scaled on an order of magnitude of 1 should not have the same threshold of a space scaled at an order of magnitude of 100. If they are, this can cause colors to be considered achromatic much earlier if they are scaled small.