feat: Add GitHub Copilot Coding Agent configs#389
Conversation
|
@copilot exclude security and code quality process aspects |
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
…ocumentation Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
I've removed the security and code quality process aspects as requested. Changes include:
The repository optimization now focuses on documentation, templates, and workflow improvements without the security/quality scanning processes. (cf05a49) |
This comment was marked as resolved.
This comment was marked as resolved.
… to CONTRIBUTING.md Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
|
@copilot we need to add more best practices:
|
…uctions, enhanced VS Code settings, MCP servers, and setup automation Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Added comprehensive GitHub Copilot optimization with all requested best practices:
All configurations validated and frontend build tested successfully. (55b4755) Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
I’ve added this to our org COPILOT_AGENT_FIREWALL_ALLOW_LIST_ADDITIONS variable |
... Thanks for adding app.codacy.com to the firewall allowlist. I can now attempt to access the Codacy issues page, though the specific API endpoints aren't returning structured data. I'll continue with static code analysis to identify and fix common code quality issues that Codacy typically flags, focusing on the files in this PR branch. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
You can also try reading https://github.com/facioquo/stock-charts/pull/389/checks?check_run_id=43439461816 for issues |
… modernize array operations, fix semicolons Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
…ncial.js Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
I accessed the GitHub checks page but it returned a web app requiring JavaScript execution. However, I performed static code analysis and identified code quality issues that Codacy typically flags. Fixed 5 trailing comma violations in chartjs-chart-financial.js. Build verified successful after changes. (09ea221) Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Most of these issues are about linting errors in markdown files. Ensure you’re setup to adhere to |
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
... Fixed all markdownlint issues in markdown files with particular attention to copilot instructions file. Added proper blank lines around headings, lists, and fenced code blocks, specified language for code blocks, and ensured trailing newlines. All files now pass markdownlint validation. (1886633) Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive GitHub Copilot Coding Agent configurations by adding documentation, templates, workflows, and code improvements for linting, error handling, and null safety.
- Enhanced repository documentation and contribution guides with build/test instructions and code quality standards
- Added automated CI/CD workflows, Dependabot settings, and VS Code tasks/settings/extensions for Copilot optimization
- Updated application code with strict equality checks, safer null handling, and structured error logging
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/CONTRIBUTING.md | Added building and testing instructions for backend & frontend |
| docs/CODE_QUALITY.md | New code quality improvements document |
| client/src/assets/js/chartjs-chart-financial.js | Removed trailing commas to align with ESLint comma-dangle rule |
| client/src/app/services/utility.service.ts | Added semicolons, strict equality, and safe element checks |
| client/src/app/services/user.service.ts | Changed null check for settings from loose to strict |
| client/src/app/services/config.service.ts | Updated fill logic and added missing semicolon |
| client/src/app/services/chart.service.ts | Multiple strict-equality updates, guards, and improved error logging |
| client/src/app/services/api.service.ts | Used strict equality, improved error logging |
| client/src/app/components/picker/pick-config.component.ts | Typed errorMessage and enhanced error logging |
| client/package.json | Added lint scripts and ESLint/markdownlint dependencies |
| client/eslint.config.js | New flat ESLint configuration |
| .vscode/tasks.json | VS Code tasks for building and running client/server |
| .vscode/settings.json | VS Code and Copilot editor settings |
| .vscode/extensions.json | Recommended VS Code extensions |
| .markdownlint.json | MarkdownLint rules configuration |
| .github/dependabot.yml | Dependabot configuration for NuGet, npm, and Actions |
| .github/copilot-setup-steps.yml | Pre-session Copilot environment setup workflow |
| .github/copilot-mcp-servers.json | Model Context Protocol servers configuration |
| .github/copilot-instructions.md | Detailed Copilot instructions for this project |
Comments suppressed due to low confidence (1)
client/src/app/services/config.service.ts:277
- Switching from
c.fill == nulltoc.fill === nullchanges behavior ifc.fillisundefined. Consider usingc.fill == null(loose check) or explicitly checking bothnullandundefinedto maintain original logic.
fill: c.fill === null ? false : {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
This PR optimizes the repository for GitHub Copilot Coding Agent usage by implementing comprehensive documentation, templates, and automation following GitHub's best practices.
🎯 What's Changed
Issue & PR Templates
Enhanced Documentation
Automated Workflows
Repository Organization
main) and workflowSecurity & Quality
🤖 AI Agent Optimization
The repository now includes:
📋 Testing
npm run build)🔗 Reference
Implementation follows GitHub Copilot Coding Agent Best Practices
Fixes #388.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
http://168.63.129.16:80/machine//usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.