chore: Update packages (w/ Angular v20)#397
Conversation
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
… 20 compatibility Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
|
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
|
…20 application Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
I've successfully added comprehensive unit tests for the Angular v20 application using Jest (Angular's preferred testing framework). The implementation includes: ✅ Jest Testing Framework Setup - Complete configuration with Angular-specific setup
Test Coverage:
All tests pass successfully and confirm the color picker is working correctly with the Angular v20 upgrade. Added test scripts: Commit: 8808d0b |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Angular application to v20 while aligning package versions, updating code formatting and lint configurations, and adding test commands and Jest configuration.
- Upgraded Angular, Angular Material, CLI, and TypeScript versions
- Revised ESLint configuration and removed the legacy eslint.config.js
- Updated package.json scripts and added additional test configuration files
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/app/pages/chart/* | Updated formatting to use double quotes consistently |
| client/src/app/pages/404/* | Consistent quote adjustments and formatting changes |
| client/src/app/components/picker/* | Updated import paths and formatting; no logic changes |
| client/src/app/app.* | Minor formatting changes with updated configuration |
| client/package.json | Upgraded dependencies and updated npm scripts |
| client/jest.config.js | Added new Jest configuration |
| client/eslint.config.js | Legacy ESLint configuration removed |
| client/angular.json & client/.eslintrc.json | Updated configuration to integrate Angular ESLint and schematics |
| .github/copilot-setup-steps.yml | Minor update with added descriptive comment |
Comments suppressed due to low confidence (1)
client/eslint.config.js:1
- Ensure that the removal of the legacy eslint.config.js file is intentional and that all necessary ESLint rules have been fully migrated to .eslintrc.json to maintain code quality.
export default [
|
Fix these issues: ANNOTATIONS Check failure on line 1 in client/src/app/components/picker/color-picker.spec.ts @codacy-production client/src/app/components/picker/color-picker.spec.ts#L1 @codacy-production client/src/app/components/picker/color-picker.spec.ts#L2 @codacy-production client/src/app/components/picker/color-picker.spec.ts#L111 |
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Fixed all Codacy static analysis issues:
Commit: ac8670a |
|
|
… package overrides Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Fixed all controllable npm install warnings by updating dependencies and adding package overrides: ✅ Major fixes: Eliminated all ERESOLVE peer dependency conflicts through Angular 20 package overrides The remaining 4 warnings are from Jest testing dependencies and cannot be eliminated without breaking the testing framework. Commit: a46d458 |
…s workflow Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Added comprehensive unit test execution and coverage reporting to the GitHub Actions workflow: ✅ Unit Test Integration - Tests run automatically using The workflow now runs 27 unit tests and provides comprehensive coverage reporting in the build summary. Commit: f3f8094 Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
| run: npm run test:coverage | ||
|
|
||
| - name: Publish test results | ||
| uses: dorny/test-reporter@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| reporter: jest-junit | ||
|
|
||
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/codecov-action@v5 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| fail_ci_if_error: false | ||
|
|
||
| - name: Coverage Report | ||
| uses: romeovs/lcov-reporter-action@v0.3.1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
@copilot fix deploy-website.yml error Run cloudflare/wrangler-action@v3 🔍 Checking for existing Wrangler installation |
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Fixed the Cloudflare Wrangler deployment error by removing the problematic |
This PR upgrades the Angular application from v19.1.4 to v20.0.1, addressing all requirements in the issue:
Changes Made
Angular Framework Upgrade
Package Updates
Code Quality Improvements
observer.next()calls to provide proper values as required by updated RxJSPerformance Improvements
Testing
npm auditclean)Breaking Changes
None - this is a compatible upgrade that maintains all existing functionality.
UI Picker & Color Selector Verification
The color picker components using
@ng-matero/extensionsandngx-colorhave been verified to:Fixes #396.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.comng build --configuration=production(dns block)http://168.63.129.16:80/machine//usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.