Skip to content

Fix Chart.js integration for financial chart rendering with candlestick and volume display #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 22 commits into from

Restore candlestick chart implementation and fix code quality issues

54fb5d6
Select commit
Loading
Failed to load commit list.
Closed

Fix Chart.js integration for financial chart rendering with candlestick and volume display #422

Restore candlestick chart implementation and fix code quality issues
54fb5d6
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Oct 12, 2025 in 0s

8 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 8
           

Complexity increasing per file
==============================
- client/src/app/services/chart.service.ts  1
- server/WebApi/Program.cs  1
- client/src/app/components/picker/pick-config.component.ts  5
- server/WebApi/Endpoints.cs  7
- client/src/app/data/backup-quotes.ts  4
- client/src/chartjs/financial/register-financial.ts  4
- client/src/chartjs/financial/register-financial.spec.ts  5
- client/src/chartjs/financial/financial-controller.ts  10
- client/src/chartjs/financial/candlestick-controller.ts  12
- client/src/chartjs/financial/financial-element.ts  12
- client/src/chartjs/financial/colors.ts  7
- client/src/chartjs/financial/factories.ts  32
- client/src/chartjs/financial/candlestick-element.ts  11
- client/src/chartjs/financial/ohlc-controller.ts  5
- client/src/chartjs/financial/ohlc-element.ts  16
- server/WebApi/Services/QuoteFileFallback.cs  8
- server/WebApi.Tests/Services/QuoteFileFallbackTests.cs  3
- client/src/app/data/backup-quotes.spec.ts  11
- server/WebApi.Tests/Endpoints/QuotesEndpointTests.cs  8
         

Complexity decreasing per file
==============================
+ server/WebApi/Services/Service.Quotes.Failover.cs  -477
+ server/WebApi.Tests/Services/RandomQuotesTests.cs  -1
         

Clones added
============
- client/src/chartjs/financial/candlestick-controller.ts  1
- client/src/chartjs/financial/ohlc-controller.ts  1
- server/WebApi.Tests/Endpoints/QuotesEndpointTests.cs  2

See the complete overview on Codacy

Annotations

Check warning on line 19 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L19 

This loop's stop condition tests 'list' and 'target' but the incrementer updates 'dayOffset'.

Check notice on line 22 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L22 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 23 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L23 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 30 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L30 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 31 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L31 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 67 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L67 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 68 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L68 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 69 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L69 

Add curly braces around the nested statement(s) in this 'if' block.
View more details on Codacy Production