Skip to content

fix: Resolve test failures and VitePress build errors#456

Merged
DaveSkender merged 3 commits intoreusable-chartsfrom
copilot/sub-pr-454
Feb 19, 2026
Merged

fix: Resolve test failures and VitePress build errors#456
DaveSkender merged 3 commits intoreusable-chartsfrom
copilot/sub-pr-454

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

Two critical issues blocked PR validation: all Angular tests failing with TestBed initialization errors, and VitePress documentation build failing with module resolution and dead link errors.

Test Setup Fix

Angular TestBed was throwing "Cannot set base providers because it has already been called" when Vitest's setupFiles imported test-setup.ts for each test file. Added try-catch guard:

// client/src/test-setup.ts
try {
  destroyPlatform();
  getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
} catch (error) {
  if (!(error as Error).message?.includes("Cannot set base providers")) {
    throw error;
  }
}

Result: 84 tests passing, 1 skipped.

VitePress Documentation Fixes

  • Built libs/chartjs-financial and libs/indy-charts packages (missing dist directories)
  • Replaced relative paths with GitHub URLs to avoid dead link validation errors
  • Created missing guide/api-client.md page

VitePress now builds successfully.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…te initialization errors

Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 19, 2026

Deploying stock-charts with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1605a52
Status: ✅  Deploy successful!
Preview URL: https://b7dc9eac.stock-charts.pages.dev
Branch Preview URL: https://copilot-sub-pr-454.stock-charts.pages.dev

View logs

Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 19, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh pr view --json reviews,comments (http block)
    • Triggering command: /usr/bin/gh gh pr view --json reviews (http block)
    • Triggering command: /usr/bin/gh gh pr view --json comments (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address unresolved comments in pull request for reusable charts fix: Resolve test failures and VitePress build errors Feb 19, 2026
Copilot AI requested a review from DaveSkender February 19, 2026 10:09
@DaveSkender DaveSkender marked this pull request as ready for review February 19, 2026 10:42
@DaveSkender DaveSkender merged commit 955d86e into reusable-charts Feb 19, 2026
1 check passed
@DaveSkender DaveSkender deleted the copilot/sub-pr-454 branch February 19, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants