Skip to content

Fix memory leak in Parser from unowned root_field allocation #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix memory leak in Parser from unowned root_field allocation #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa65775
Initial plan
Copilot Oct 27, 2025
7987ea6
Fix memory leak in Parser by managing root_field lifetime
Copilot Oct 27, 2025
9bbdce9
Add .gitignore entry for codeql artifacts
Copilot Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/build/*
*.csv
/build*
_codeql_*
1 change: 1 addition & 0 deletions include/rosx_introspection/ros_message.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ struct MessageSchema {
FieldTree field_tree;
ROSMessage::Ptr root_msg;
RosMessageLibrary msg_library;
std::unique_ptr<ROSField> root_field;
};

//------------------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions src/ros_message.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ MessageSchema::Ptr BuildMessageSchema(const std::string& topic_name, const std::
}; // end of recursiveTreeCreator

// build root and start recursion
auto root_field = new ROSField(schema->root_msg->type(), topic_name);
schema->field_tree.root()->setValue(root_field);
schema->root_field = std::make_unique<ROSField>(schema->root_msg->type(), topic_name);
schema->field_tree.root()->setValue(schema->root_field.get());

recursiveTreeCreator(schema->root_msg, schema->field_tree.root());

Expand Down