Skip to content

'adding-organizations-form'#130

Open
RRonier wants to merge 1 commit intofactn:masterfrom
RRonier:feat/119-resilience-organizations-form
Open

'adding-organizations-form'#130
RRonier wants to merge 1 commit intofactn:masterfrom
RRonier:feat/119-resilience-organizations-form

Conversation

@RRonier
Copy link

@RRonier RRonier commented Aug 14, 2020

I've added the get resilience form for organizations.

@netlify
Copy link

netlify bot commented Aug 14, 2020

Deploy preview for resilience-landing-page ready!

Built with commit b3430bc

https://deploy-preview-130--resilience-landing-page.netlify.app

Comment on lines +130 to +135
/*
container
alignItems="center"
alignContent="center"
className={classes.grid}
*/ No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments you can probably remove

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove those, thank you

const Form = () => {
const classes = useStyles();
return (
<>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had time to look at material's components, do we need to wrap this all in a <form> ?

https://docs.netlify.com/forms/setup/

Also see netlify forms for form setup.

Do we also need to establish a route this will be rendered on? Just based of these changes it looks like we've made the component, but it won't be loaded anywhere

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt added any route because on zendhub was another ticket for that. I know we need to wrap the compoment into a form, I'll add it now, thanks. I'll just check for the netlify forms

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup you should be able to just add netlify to the form element or data-netlify="true", the docs cover it. But should be good to check with Daniel or Miles on what we're expecting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're using Gatsby, you'll need to add a hidden input like this guy:
<input type="hidden" name="form-name" value="contact" />
Per: https://www.netlify.com/blog/2017/07/20/how-to-integrate-netlifys-form-handling-in-a-react-app/#form-handling-with-static-site-generators

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessdwitch is the hidden input the same as a honeypot input that gatsby expects?

Ive barely dabbled with netlify forms and it seems like a perfect free solution for what we needed with this contact form

@jwu910
Copy link
Member

jwu910 commented Aug 14, 2020

Would be good to check in with the designers and @utunga To see how users should be getting to the form, and then what happens when it's submitted

@jwu910
Copy link
Member

jwu910 commented Aug 14, 2020

#116

@RRonier You're right, this sounds like we should get this one done first, and then we can create the page/route on the other ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants