Skip to content

fix: 🐛 Fix potential warning in factory.py #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix: 🐛 Fix potential warning in factory.py #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions patterns/creational/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@


class Localizer(Protocol):
def localize(self, msg: str) -> str:
pass
def localize(self, msg: str) -> str: ...
Copy link
Contributor

@grimley517 grimley517 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - definitely more in line with modern usage. However; shouldn't the ellipsis go on the next line?

Copy link
Contributor Author

@Sorrow-Scarlet Sorrow-Scarlet Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I equipped black formatter as requested.
Black formatter insists that ellipsis go the exact same line with the function

Copy link
Contributor

@grimley517 grimley517 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.



class GreekLocalizer:
Expand Down
Loading