Fix bulkhead race condition #395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation made it possible for permit to be acquired, but client code getting `BulkheadFullException` resulting in permit leak.
mar-kolya
force-pushed
the
fix-bulkhead
branch
from
541df1c to
e8e62d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of race conditions in Bulkhead implementation that resulted in permits leaking and eventually all processing protected by bulkhead stopping.
This PR is split by commit and adds comments to the code hopefully explaining what is going on.
This should fix issues outlined in #393 - and in fact it uses reproducer code provided there as an inspiration for the test.
Thanks!