Draft
Conversation
Show expand button only when it is necessary Adjust alignment (center everything except url) Always show sorting arror Adjust header font Adjust body font Adjust icon sizes Smaller font size for stdout and stderror Show expand button only if there is stderr or stdout Show stderr and stdout only when they exist
sverhoeven
requested changes
Mar 8, 2021
Member
There was a problem hiding this comment.
I verifed that expand button has moved and is only shown when stderr|stdout is truthy, good job
When expanded the collapse button moves out of screen. Can a scrollbar be added to the stdout/stderr div?
Showing the sort icons always is confusing to me. Which column is it sorted on now is not clear. Can the icons of non-sorted colums be hidden or grayed out?
| }, { | ||
| name: 'expand', | ||
| required: true, | ||
| label: '', |
Member
There was a problem hiding this comment.
Can log be used as text inside the header?
Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #44 #45
Changes
How to test
Example file content:
fairtally --input-file rsd-urls.txttally.htmlwith the screenshot belowScreenshot
