Skip to content

Conversation

@dbroemmel
Copy link

@dbroemmel dbroemmel commented Nov 20, 2025

Checklist

  • Code follows the contributing guidelines of the project
  • This PR solves an existing issue and provided solution was discussed
  • The fix has been locally tested
  • Code follows the project's coding standards
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • The documentation has been updated to reflect the new feature

List of related issues or pull requests

Briefly describe the changes made in this pull request

I would hope the only change necessary was to allow for longer paths with more 'directories'. That way, the 'owner' becomes a longer path instead of a single user/group.

Additional Notes

Tested on one of our local gitlab instances and with https://gitlab.com/hifis/hifis-workshops/make-your-code-ready-for-publication/astronaut-analysis. The latter repository has been added to the livetests.

I don't think changes to the documentation are necessary.

Instructions to review the pull request

# make a new temporary directory and cd into it
cd $(mktemp -d --tmpdir howfairis.XXXXXX)

# get a copy of the repo
git clone https://github.com/fair-software/howfairis .

# checkout the work from this branch 
git checkout <this branch>

# create a virtual environment named venv3
python3 -m venv venv3

# activate the virtual environment
source venv3/bin/activate

# update pip and friends
python3 -m pip install --upgrade pip wheel setuptools

# install runtime dependencies
python3 -m pip install .

# and, if you need it, the development tools
python3 -m pip install .[dev]

Keep what you need from below, extend as necessary

# run the unit tests
pytest

# tests against a live infrastructure
howfairis https://gitlab.com/hifis/hifis-workshops/make-your-code-ready-for-publication/astronaut-analysis

Adding a livetest of a group repository on gitlab.com. This repository
may disappear at some point, so the test is brittle.
It would be better if a maintainer created a group/subgroup and fork
'jspaaks/howfairis-livetest' into this subgroup for testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant