chore(deps): update dependency @vitest/eslint-plugin to v1.6.3 by renovate[bot] · Pull Request #3645 · faker-js/faker

fix(consistent-test-it): Handle aliased Vitest imports when enforcing consistent test names by @y-hsgw in #828
feat: Add rule to recommended Vitest ESLint config by @y-hsgw in #827

Full Changelog: vitest-dev/eslint-plugin-vitest@v1.4.4...v1.5.0

`v1.4.4`

Compare Source

🚀 Features

Adding require-import-vi-mock rule - by @axel7083 in #820 (abdea)
Add rule consistent-each-for - by @figueiredoluiz in #826 (db570)

🐞 Bug Fixes

expect-expect: Potential false positives for expect-expect and valid-title when using it.scoped - by @y-hsgw in #822 (765ee)
no-identical-title: FP when using test.for - by @y-hsgw in #825 (962de)

View changes on GitHub

What's Changed

fix(expect-expect): Potential false positives for expect-expect and valid-title when using it.scoped by @y-hsgw in #822
feat: adding require-import-vi-mock rule by @axel7083 in #820
docs(prefer-equality-matcher): correct (e)quality typo in description by @JoshuaKGoldberg in #824
fix(no-identical-title): FP when using test.for by @y-hsgw in #825
feat: add rule consistent-each-for by @figueiredoluiz in #826

New Contributors

@axel7083 made their first contribution in #820
@figueiredoluiz made their first contribution in #826

Full Changelog: vitest-dev/eslint-plugin-vitest@v1.4.3...v1.4.4

`v1.4.3`

Compare Source

🐞 Bug Fixes

prefer-called-exactly-once-with: Preserve TypeScript generic parameters - by @G-Rath in #818 (2e3e9)

View changes on GitHub

`v1.4.2`

Compare Source

🚀 Features

Add rule require-awaited-expect-poll - by @StyleShit in #817 (ebf57)

View changes on GitHub

What's Changed

refactor: Enforce no-unsafe-optional-chaining as an Error by @y-hsgw in #816
feat: add rule require-awaited-expect-poll by @StyleShit in #817

New Contributors

@StyleShit made their first contribution in #817

Full Changelog: vitest-dev/eslint-plugin-vitest@v1.4.1...v1.4.2

`v1.4.1`

Compare Source

No significant changes

View changes on GitHub

`v1.4.0`

Compare Source

🐞 Bug Fixes

Add describe.for chains - by @paescuj in #808 (97702)
Workaround for plugin type - by @paescuj in #811 (30053)
Make .extend exclusive, add .scoped - by @paescuj in #809 (70708)
no-done-callback: Remove rule from 'all' list - by @paescuj in #807 (20e53)

View changes on GitHub

`v1.3.26`

Compare Source

🐞 Bug Fixes

Dynamically require typescript - by @paescuj in #803 (2ff2d)
no-done-callback: False positive when using .for - by @paescuj in #804 (a3ab8)

View changes on GitHub

`v1.3.25`

Compare Source

🐞 Bug Fixes

consistent-test-filename: Correct expected options type - by @paescuj in #801 (8a14d)

View changes on GitHub

`v1.3.24`

Compare Source

🐞 Bug Fixes

no-standalone-expect: Add it.for/test.for chains - by @y-hsgw in #800 (7558b)

View changes on GitHub

`v1.3.23`

Compare Source

No significant changes

View changes on GitHub

`v1.3.22`

Compare Source

No significant changes

View changes on GitHub

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

netlify · 2025-11-01T00:32:47Z

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	`9a65df9`
🔍 Latest deploy log	https://app.netlify.com/projects/fakerjs/deploys/694ec2fae373a50008ce1593
😎 Deploy Preview	https://deploy-preview-3645.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

This commit fixes the autofixable lint errors introduced through the vitest lint plugin update. This mostly reverts the changes introduced in #2098, where .toThrowError was replaced by .toThrow. Apprently, the plugin got it the wrong way around. For more information, look at the fixing PR in their plugin: vitest-dev/eslint-plugin-vitest#832

This change was previously not possible, since the vitest plugin was not conform with the expected eslint config typescript type. This was fixed in vitest-dev/eslint-plugin-vitest#811

As described by the comment in the config file, we require conditional logic when iterating over faker instances or doing generic test over an entire faker instance. We might want to look at vitests [test.skipIf](https://vitest.dev/api/#test-skipif) api in the future, tho.

This commit fixes warnings from the eslint rule [vitest/no-disabled-tests](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-disabled-tests.md). This is technically optional!!! I jsut wanted the lint log to look clean.

xDivisionByZerox · 2025-12-26T17:03:30Z

There where some changes required to get the vitest eslint plugin to run on the most up to date version. I've did separate commits that explain why changes where required:

Commit	Change	Reason
`c75363b`	autofix lint errors	This commit fixes the autofixable lint errors introduced through the vitest lint plugin update. This mostly reverts the changes introduced in #2098, where .toThrowError was replaced by .toThrow. Apparently, the plugin got it the wrong way around. For more information, look at the fixing PR in their plugin: vitest-dev/eslint-plugin-vitest#832
`aa25823`	Fix error on type checking by correctly extending eslint config from vitest preset	This change was previously not possible, since the vitest plugin was not conform with the expected eslint config typescript type. This was fixed in vitest-dev/eslint-plugin-vitest#811
`0424a25`	disable vitest/no-conditional-expect	We require conditional logic when iterating over faker instances or doing generic test over an entire faker instance. We might want to look at vitests test.skipIf api in the future, tho.
`03f788c` (PARTIALLY REVERTED!!!)	remove lint warnings from it.skip	This commit fixes warnings from the eslint rule vitest/no-disabled-tests. This is technically optional!!! I just wanted the lint log to look clean.

Hope this helps verifying the changes.

This commit partially reverts 03f788c because the test will not run otherwise 💀

codecov · 2025-12-26T17:19:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (8794cac) to head (9a65df9).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #3645   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2995     2995           
  Lines      236324   236324           
  Branches      941      940    -1     
=======================================
  Hits       236267   236267           
  Misses         57       57

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

xDivisionByZerox

Since I contributed the majority of changes to get the plugin to work, I'm waiting for a second approval in this dependency update PR.

renovate · 2025-12-26T17:42:36Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels Nov 1, 2025

renovate bot requested a review from a team as a code owner November 1, 2025 00:32

renovate bot added this to the vAnytime milestone Nov 1, 2025

renovate bot force-pushed the renovate/vitest branch 2 times, most recently from 9d0c15c to 5f1647c Compare November 5, 2025 12:53

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.4.0~~ chore(deps): update dependency @vitest/eslint-plugin to v1.4.1 Nov 5, 2025

renovate bot force-pushed the renovate/vitest branch 9 times, most recently from 5a59aa8 to 503aed8 Compare November 9, 2025 17:13

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.4.1~~ chore(deps): update dependency @vitest/eslint-plugin to v1.4.2 Nov 9, 2025

renovate bot force-pushed the renovate/vitest branch 2 times, most recently from 1e21436 to 7e063fb Compare November 10, 2025 08:49

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.4.2~~ chore(deps): update dependency @vitest/eslint-plugin to v1.4.3 Nov 17, 2025

renovate bot force-pushed the renovate/vitest branch 2 times, most recently from 3dc09e5 to 2b906be Compare November 18, 2025 22:30

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.4.3~~ chore(deps): update dependency @vitest/eslint-plugin to v1.4.2 Nov 18, 2025

renovate bot force-pushed the renovate/vitest branch 2 times, most recently from 445dfac to 28d20f8 Compare November 20, 2025 01:11

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.4.2~~ chore(deps): update dependency @vitest/eslint-plugin to v1.4.3 Nov 20, 2025

renovate bot force-pushed the renovate/vitest branch 2 times, most recently from 375fbf1 to 219b22b Compare November 27, 2025 06:56

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.4.3~~ chore(deps): update dependency @vitest/eslint-plugin to v1.4.4 Nov 27, 2025

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.5.1~~ chore(deps): update dependency @vitest/eslint-plugin to v1.5.2 Dec 10, 2025

renovate bot force-pushed the renovate/vitest branch 5 times, most recently from 1e8c006 to 64a4999 Compare December 22, 2025 09:05

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.5.2~~ chore(deps): update dependency @vitest/eslint-plugin to v1.5.4 Dec 22, 2025

renovate bot force-pushed the renovate/vitest branch from 64a4999 to c6c0172 Compare December 25, 2025 08:57

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.5.4~~ chore(deps): update dependency @vitest/eslint-plugin to v1.6.1 Dec 25, 2025

renovate bot force-pushed the renovate/vitest branch 2 times, most recently from 0ece0d8 to ce96d3c Compare December 26, 2025 05:43

renovate bot changed the title ~~chore(deps): update dependency @vitest/eslint-plugin to v1.6.1~~ chore(deps): update dependency @vitest/eslint-plugin to v1.6.3 Dec 26, 2025

renovate bot force-pushed the renovate/vitest branch from ce96d3c to 3e4bf89 Compare December 26, 2025 15:57

chore(deps): update dependency @vitest/eslint-plugin to v1.6.3

fb271d4

renovate bot force-pushed the renovate/vitest branch from 3e4bf89 to fb271d4 Compare December 26, 2025 16:17

xDivisionByZerox added 4 commits December 26, 2025 17:34

chore: correctly extend eslint config part from vitest preset

aa25823

This change was previously not possible, since the vitest plugin was not conform with the expected eslint config typescript type. This was fixed in vitest-dev/eslint-plugin-vitest#811

test: remove lint warnings from it.skip

03f788c

This commit fixes warnings from the eslint rule [vitest/no-disabled-tests](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-disabled-tests.md). This is technically optional!!! I jsut wanted the lint log to look clean.

test: reinstantiate it.skip test

9a65df9

This commit partially reverts 03f788c because the test will not run otherwise 💀

xDivisionByZerox requested a review from Shinigami92 December 26, 2025 17:18

xDivisionByZerox approved these changes Dec 26, 2025

View reviewed changes

Shinigami92 approved these changes Dec 26, 2025

View reviewed changes

xDivisionByZerox added this pull request to the merge queue Dec 26, 2025

Merged via the queue into next with commit d656a82 Dec 26, 2025
23 checks passed

xDivisionByZerox deleted the renovate/vitest branch December 26, 2025 18:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

chore(deps): update dependency @vitest/eslint-plugin to v1.6.3#3645

chore(deps): update dependency @vitest/eslint-plugin to v1.6.3#3645
xDivisionByZerox merged 6 commits intonextfrom
renovate/vitest

renovate bot commented Nov 1, 2025 •

edited

Loading

Uh oh!

netlify bot commented Nov 1, 2025 •

edited

Loading

Uh oh!

xDivisionByZerox commented Dec 26, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 26, 2025 •

edited

Loading

Uh oh!

xDivisionByZerox left a comment

Uh oh!

renovate bot commented Dec 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

renovate bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

🚀 Features

What's Changed

New Contributors

🐞 Bug Fixes

What's Changed

🐞 Bug Fixes

🐞 Bug Fixes

🚀 Features

🐞 Bug Fixes

What's Changed

🚀 Features

🐞 Bug Fixes

What's Changed

New Contributors

🐞 Bug Fixes

🚀 Features

What's Changed

New Contributors

🐞 Bug Fixes

🐞 Bug Fixes

🐞 Bug Fixes

🐞 Bug Fixes

Configuration

Uh oh!

netlify bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fakerjs ready!

Uh oh!

xDivisionByZerox commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xDivisionByZerox left a comment

Choose a reason for hiding this comment

Uh oh!

renovate bot commented Dec 26, 2025

Edited/Blocked Notification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

renovate bot commented Nov 1, 2025 •

edited

Loading

netlify bot commented Nov 1, 2025 •

edited

Loading

xDivisionByZerox commented Dec 26, 2025 •

edited

Loading

codecov bot commented Dec 26, 2025 •

edited

Loading