Skip to content

Conversation

@luke-hill
Copy link
Contributor

This PR aims to improve the false failure hit-rate for UK Phone numbers. Partially alleviates #3135

Additional information

Reference from Ofcom drama list: https://www.ofcom.org.uk/phones-and-broadband/phone-numbers/numbers-for-drama

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! The commit message has enough context, so no need for these comments.

@thdaraujo thdaraujo merged commit c86d9ea into faker-ruby:main Nov 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants