feat(typing): parametrize App by default req/resp types on 3.13+#2591
Merged
vytas7 merged 6 commits intofalconry:masterfrom Jan 21, 2026
Merged
feat(typing): parametrize App by default req/resp types on 3.13+#2591vytas7 merged 6 commits intofalconry:masterfrom
vytas7 merged 6 commits intofalconry:masterfrom
Conversation
Co-authored-by: Jasper Spaans <j@jasper.es>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2591 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7874 7875 +1
Branches 1078 1078
=========================================
+ Hits 7874 7875 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CaselIT
approved these changes
Jan 21, 2026
| if is_sink: | ||
| params = m.groupdict() # type: ignore[union-attr] | ||
| responder = obj | ||
| responder = obj # type: ignore[assignment,unused-ignore] |
Member
Author
There was a problem hiding this comment.
Our typing is inexact, and not parametrized properly either, but this is masked on <=3.12 by earlier ignores/casts. On, 3.13 it applies the default leading to further mismatch, as I understand.
Member
There was a problem hiding this comment.
Oh ok, so we have a type warning only in some python version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the idea @jap, I took a stab @ implementing this.
Fixes #2586.