feat(asgi): no longer add NullHandler to the falcon logger#2595
Merged
vytas7 merged 1 commit intofalconry:masterfrom Jan 18, 2026
Merged
feat(asgi): no longer add NullHandler to the falcon logger#2595vytas7 merged 1 commit intofalconry:masterfrom
NullHandler to the falcon logger#2595vytas7 merged 1 commit intofalconry:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2595 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7875 7874 -1
Branches 1078 1078
=========================================
- Hits 7875 7874 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CaselIT
approved these changes
Jan 18, 2026
Member
CaselIT
left a comment
There was a problem hiding this comment.
Makes sense to me.
I think it's fine to keep as part of a point release.
Member
Author
Aye, don't think it's an issue SemVer wise since it's an implementation detail of the private |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to add a
NullHandler()tofalcon._loggerwhich could be done according to the stdlib's docs,However, this has mostly resulted in confusion for people trying the ASGI flavour of the framework as HTTP 500 tracebacks may disappear completely, so the revised choice is NOT to prevent last resort logging to
sys.stderr.Fixes #2594.