refactor(falco): migrate to Server-Side Apply for resource management#223
Merged
poiana merged 6 commits intofalcosecurity:mainfrom Feb 5, 2026
Merged
refactor(falco): migrate to Server-Side Apply for resource management#223poiana merged 6 commits intofalcosecurity:mainfrom
poiana merged 6 commits intofalcosecurity:mainfrom
Conversation
poiana
added
kind/cleanup
dco-signoff: yes
kind/feature
alacuku
reviewed
Feb 1, 2026
c2ndev
force-pushed
the
refactor/ssa-and-tests
branch
from
5cde9ee to
d20089c
Compare
Contributor
Author
|
@alacuku I have reintroduced the diff mechanism as you suggested. When you want, you can procede with the review :) Thank you! EDIT: I'm still implementing the managedFields diff |
c2ndev
changed the title
c2ndev
force-pushed
the
refactor/ssa-and-tests
branch
4 times, most recently
from
9c34a1f to
6db5493
Compare
c2ndev
changed the title
alacuku
reviewed
Feb 3, 2026
c2ndev
force-pushed
the
refactor/ssa-and-tests
branch
from
aa56878 to
31b08d3
Compare
c2ndev
force-pushed
the
refactor/ssa-and-tests
branch
from
31b08d3 to
af483c8
Compare
Signed-off-by: cannarelladev <cannarella.dev@gmail.com>
Signed-off-by: cannarelladev <cannarella.dev@gmail.com>
Signed-off-by: cannarelladev <cannarella.dev@gmail.com>
Signed-off-by: c2ndev <cannarella.dev@gmail.com>
Signed-off-by: cannarelladev <cannarella.dev@gmail.com>
Signed-off-by: cannarelladev <cannarella.dev@gmail.com>
c2ndev
force-pushed
the
refactor/ssa-and-tests
branch
from
af483c8 to
d2bf61d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, c2ndev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: a73efe05950259b80ccdc5bea896e056809d9b26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area falco-operator
/area artifact-operator
What this PR does / why we need it:
This PR refactors the Falco controller to use Kubernetes Server-Side Apply (SSA) instead of the previous dry-run + diff pattern for creating and updating resources.
Key improvements:
ResourceVersioncomparison which is correctly supported by Kubernetes >= 1.31)Benefits:
Which issue(s) this PR fixes:
Fixes #222
Special notes for your reviewer:
During deletion, the informer cache may trigger multiple reconciliations for the same event. This results in duplicate log entries (cosmetic) but has no functional impact — the finalizer removal patch is idempotent and only the first one takes effect.