Skip to content

fix: add RBAC patch verb for artifacts and K8s 1.32+ schema compatibility#234

Merged
poiana merged 1 commit intofalcosecurity:mainfrom
c2ndev:fix/rbac-patch-verb-and-k8s-schema
Feb 9, 2026
Merged

fix: add RBAC patch verb for artifacts and K8s 1.32+ schema compatibility#234
poiana merged 1 commit intofalcosecurity:mainfrom
c2ndev:fix/rbac-patch-verb-and-k8s-schema

Conversation

@c2ndev
Copy link
Contributor

@c2ndev c2ndev commented Feb 9, 2026

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-operator

/area artifact-operator

/area pkg

/area api

/area docs

What this PR does / why we need it:

Fixes two bugs discovered during e2e testing:

  1. RBAC: Adds patch verb to the Role generated for the artifact-operator sidecar (controllers/falco/role.go). The artifact-operator uses client.MergeFrom + Patch to add finalizers on Config/Rulesfile/Plugin CRs, which requires the patch permission.

  2. Schema: Adds terminatingReplicas to the embedded DeploymentStatus schema (internal/pkg/scheme/parser.go). Kubernetes 1.32+ added this field to apps/v1/Deployment status, causing structured-merge-diff to reject Deployment objects when parsing managed fields. The addition is backward compatible with older K8s versions.

Which issue(s) this PR fixes:

Fixes #233

Special notes for your reviewer:

…lity

Signed-off-by: cannarelladev <cannarella.dev@gmail.com>
@poiana poiana added the lgtm label Feb 9, 2026
@poiana
Copy link

poiana commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c2ndev, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Feb 9, 2026
@poiana
Copy link

poiana commented Feb 9, 2026

LGTM label has been added.

DetailsGit tree hash: 7fdef223bedea501974845d65fdd6366c345dfb4

@poiana poiana merged commit 7c7962e into falcosecurity:main Feb 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RBAC missing patch verb for artifact resources and DeploymentStatus schema incompatible with K8s 1.32+

3 participants