fix: add RBAC patch verb for artifacts and K8s 1.32+ schema compatibility#234
Merged
poiana merged 1 commit intofalcosecurity:mainfrom Feb 9, 2026
Merged
Conversation
…lity Signed-off-by: cannarelladev <cannarella.dev@gmail.com>
leogr
approved these changes
Feb 9, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c2ndev, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 7fdef223bedea501974845d65fdd6366c345dfb4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area falco-operator
/area artifact-operator
What this PR does / why we need it:
Fixes two bugs discovered during e2e testing:
RBAC: Adds
patchverb to the Role generated for the artifact-operator sidecar (controllers/falco/role.go). The artifact-operator usesclient.MergeFrom+Patchto add finalizers on Config/Rulesfile/Plugin CRs, which requires thepatchpermission.Schema: Adds
terminatingReplicasto the embeddedDeploymentStatusschema (internal/pkg/scheme/parser.go). Kubernetes 1.32+ added this field toapps/v1/Deploymentstatus, causingstructured-merge-diffto reject Deployment objects when parsing managed fields. The addition is backward compatible with older K8s versions.Which issue(s) this PR fixes:
Fixes #233
Special notes for your reviewer: