new(driver): update exit events PPME_SYSCALL_SETRESGID_X with enter params#2474
Merged
poiana merged 2 commits intofalcosecurity:masterfrom Jun 18, 2025
Merged
Conversation
poiana
added
kind/feature
Contributor
|
/milestone 0.22.0 |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
+ Coverage 77.97% 77.99% +0.02%
==========================================
Files 253 255 +2
Lines 31125 31154 +29
Branches 4645 4645
==========================================
+ Hits 24269 24298 +29
Misses 6856 6856
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
terror96
force-pushed
the
setresgid-exit-event-improvement
branch
from
cf97fe0 to
ef51167
Compare
Contributor
Author
|
I replaced gid_ts with uint32_t otherwise the windows build failed. |
Contributor
|
triggered kernel-testing: https://github.com/falcosecurity/libs/actions/runs/15608390780 |
terror96
force-pushed
the
setresgid-exit-event-improvement
branch
from
ef51167 to
e2f7022
Compare
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Contributor
Author
And then I made a typo :( |
terror96
force-pushed
the
setresgid-exit-event-improvement
branch
2 times, most recently
from
de80a69 to
7971369
Compare
Contributor
|
I re-run the kernel testing CI: https://github.com/falcosecurity/libs/actions/runs/15707488682 |
Contributor
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, terror96 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 6905844468cceaef943d6e105ff94236551a81cd |
Signed-off-by: Tero Kauppinen <tero.kauppinen@est.tech>
…arams This update is part of the implementation for disabling support for syscall enter events. It implements the following steps: 1. Adds enter parameters to the exit event 2. Adapt sinsp state to work just with exit events. 3. Create a scap-file conversion (in a dedicated scap-file converter) to convert ENTER events into merged EXIT ones. 4. Add some tests replaying scap-files. for the setresgid syscall. Signed-off-by: Tero Kauppinen <tero.kauppinen@est.tech>
terror96
force-pushed
the
setresgid-exit-event-improvement
branch
from
5ee7a4d to
88b53e4
Compare
Contributor
|
Kernel testing CI re-run: https://github.com/falcosecurity/libs/actions/runs/15726646968 |
Contributor
|
arm64:
amd64:
|
ekoops
approved these changes
Jun 18, 2025
Contributor
|
LGTM label has been added. DetailsGit tree hash: 8431dc6d728bdb5b43f6210992def7a2ee94d5f0 |
Contributor
|
/unhold |
leogr
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update is part of the implementation for disabling support for
syscall enter events. It implements the following steps:
to convert ENTER events into merged EXIT ones.
for the setresgid syscall.
This pull request also adds a missing setgid parsing test file.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-gvisor
/area libscap-engine-savefile
/area libscap
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
/version driver-API-version-minor
/version driver-SCHEMA-version-minor
What this PR does / why we need it:
This PR is part of #2068.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: