feat(libsinsp): concat transformer

[therealbobo]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2025

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[github-actions]

Perf diff from master - unit tests

    14.26%    +11.67%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
    10.51%     -7.68%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
    11.82%     -1.61%  [.] sinsp_threadinfo::get_main_thread()
    13.89%     -1.43%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     8.66%     -1.05%  [.] sinsp_threadinfo::update_main_fdtable()
     6.89%     -0.74%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     4.78%     +0.59%  [.] thread_group_info::get_first_thread() const
     3.44%     +0.43%  [.] sinsp_thread_manager::create_thread_dependencies(std::shared_ptr<sinsp_threadinfo> const&)
     8.59%     -0.35%  [.] sinsp_threadinfo::get_fd_table()
     0.01%     +0.11%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_copy()

Heap diff from master - unit tests

peak heap memory consumption: -3.61K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -32B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0102         -0.0102           237           235           237           235
BM_sinsp_split_median                                          -0.0089         -0.0090           237           235           237           235
BM_sinsp_split_stddev                                          +0.6058         +0.6152             1             2             1             2
BM_sinsp_split_cv                                              +0.6223         +0.6319             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0489         +0.0487            69            72            69            72
BM_sinsp_concatenate_paths_relative_path_median                +0.0422         +0.0426            69            72            69            72
BM_sinsp_concatenate_paths_relative_path_stddev                -0.2174         -0.2130             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.2539         -0.2495             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0466         +0.0465            41            42            41            42
BM_sinsp_concatenate_paths_empty_path_median                   +0.0698         +0.0697            41            43            40            43
BM_sinsp_concatenate_paths_empty_path_stddev                   +4.5487         +4.5692             0             2             0             2
BM_sinsp_concatenate_paths_empty_path_cv                       +4.3016         +4.3219             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0714         +0.0712            68            73            68            73
BM_sinsp_concatenate_paths_absolute_path_median                +0.0702         +0.0701            68            73            68            73
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.0308         +2.0467             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.8287         +1.8442             0             0             0             0

[codecov]

Codecov Report

❌ Patch coverage is 95.34884% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.58%. Comparing base (64da2bd) to head (b25048f).
⚠️ Report is 13 commits behind head on master.

Files with missing lines	Patch %	Lines
...sinsp/sinsp_filtercheck_multivalue_transformer.cpp	88.00%	3 Missing ⚠️
userspace/libsinsp/test/filter_transformer.ut.cpp	94.91%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2822      +/-   ##
==========================================
+ Coverage   74.48%   74.58%   +0.09%     
==========================================
  Files         294      294              
  Lines       30558    30686     +128     
  Branches     4838     4846       +8     
==========================================
+ Hits        22762    22887     +125     
- Misses       7796     7799       +3     

Flag	Coverage Δ
libsinsp	74.58% <95.34%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ekoops]

/approve

[poiana]

LGTM label has been added.

Details

Git tree hash: 1932a26b08ec0ff6052487c76bc0edb62451b75c

[terror96]

/lgtm

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, terror96, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ekoops,therealbobo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment