Skip to content

fix(ci): remove linux-tools-generic to fix dependency conflict#2828

Merged
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix/ci-linux-tools-generic
Feb 6, 2026
Merged

fix(ci): remove linux-tools-generic to fix dependency conflict#2828
poiana merged 1 commit intofalcosecurity:masterfrom
irozzo-1A:fix/ci-linux-tools-generic

Conversation

@irozzo-1A
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Remove linux-tools-generic from perf action dependencies as it causes dependency conflicts on systems with non-generic kernels (e.g., Oracle kernels). The linux-tools-uname -r package already provides the necessary kernel-specific tools, making linux-tools-generic redundant.

The following packages have unmet dependencies:
linux-tools-generic : Depends: linux-tools-6.8.0-100-generic but it is not installable
E: Unable to correct problems, you have held broken packages.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Remove linux-tools-generic from perf action dependencies as it causes
dependency conflicts on systems with non-generic kernels (e.g., Oracle
kernels). The linux-tools-`uname -r` package already provides the
necessary kernel-specific tools, making linux-tools-generic redundant.

Signed-off-by: irozzo-1A <iacopo@sysdig.com>
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Perf diff from master - unit tests

     9.47%     +4.38%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
    13.63%     -3.43%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     8.00%     +1.34%  [.] sinsp_threadinfo::get_fd_table()
    15.69%     -1.31%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     9.14%     -1.27%  [.] sinsp_threadinfo::update_main_fdtable()
     8.97%     +1.00%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     7.11%     -0.80%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     3.15%     +0.32%  [.] sinsp_thread_manager::create_thread_dependencies(std::shared_ptr<sinsp_threadinfo> const&)
     5.06%     -0.31%  [.] thread_group_info::get_first_thread() const
     0.16%     -0.12%  [.] (anonymous namespace)::plugin_parse_event(void*, ss_plugin_event_input const*, ss_plugin_event_parse_input const*)

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0382         -0.0381           247           237           247           237
BM_sinsp_split_median                                          -0.0378         -0.0374           247           237           246           237
BM_sinsp_split_stddev                                          -0.8195         -0.8209             3             1             3             1
BM_sinsp_split_cv                                              -0.8123         -0.8138             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0002         +0.0004            73            73            73            73
BM_sinsp_concatenate_paths_relative_path_median                -0.0031         -0.0029            74            73            73            73
BM_sinsp_concatenate_paths_relative_path_stddev                +0.2401         +0.2239             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.2399         +0.2235             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0572         +0.0573            42            45            42            45
BM_sinsp_concatenate_paths_empty_path_median                   +0.0506         +0.0508            42            45            42            45
BM_sinsp_concatenate_paths_empty_path_stddev                   +2.4566         +2.4807             0             1             0             1
BM_sinsp_concatenate_paths_empty_path_cv                       +2.2696         +2.2921             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0306         -0.0306            73            71            73            71
BM_sinsp_concatenate_paths_absolute_path_median                -0.0231         -0.0231            73            71            73            71
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.8587         -0.8606             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.8543         -0.8562             0             0             0             0

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.48%. Comparing base (bf876d9) to head (047c5e8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2828   +/-   ##
=======================================
  Coverage   74.48%   74.48%           
=======================================
  Files         294      294           
  Lines       30558    30558           
  Branches     4838     4838           
=======================================
  Hits        22762    22762           
  Misses       7796     7796           
Flag Coverage Δ
libsinsp 74.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops ekoops added this to the 0.24.0 milestone Feb 6, 2026
Copy link
Contributor

@ekoops ekoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 6, 2026

LGTM label has been added.

DetailsGit tree hash: de6e93235f7c2ccccd80baa2cc54c02182768927

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Feb 6, 2026
@poiana
Copy link
Contributor

poiana commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, gnosek, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ekoops,gnosek,irozzo-1A]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ca51647 into falcosecurity:master Feb 6, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants