chore!: drop legacy BPF probe#2829
Conversation
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2829 +/- ##
==========================================
+ Coverage 74.48% 74.54% +0.05%
==========================================
Files 294 294
Lines 30558 30534 -24
Branches 4838 4826 -12
==========================================
Hits 22762 22762
+ Misses 7796 7772 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Falco 0.43.0 deprecated the legacy eBPF probe, and the support will be removed soon in the next libs release. Drop any reference to it and any CI tests testing it. BREAKING CHANGE: drop all code related to legacy BPF probe Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
36bcd78 to
ce55a82
Compare
Andreagit97
left a comment
There was a problem hiding this comment.
I didn’t think I’d live long enough to see this 😆
/approve x10
I did it for you! 😂 |
| ## Rationale | ||
|
|
||
| This test suite should allow you to check the behavior of our 3 drivers: `modern_bpf`, `bpf`, `kernel module`. To assert against the output of our drivers we use the so-called `scap-engines`. | ||
| This test suite should allow you to check the behavior of our 2 drivers: `modern_bpf`, `kernel module`. To assert against the output of our drivers we use the so-called `scap-engines`. |
There was a problem hiding this comment.
We should probably consider renaming the modern_bpf driver to bpf now that it is the only one (not as part of this PR obviously, this one is already big enough).
There was a problem hiding this comment.
Agree. Not sure we should include it in the upcoming release. I would keep it as is for the moment, and move to just "ebpf" in the next release.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, deepskyblue86, ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
-15k lines🔥 |
|
/hold cancel |
What type of PR is this?
/kind cleanup
/kind design
/kind documentation
/kind test
Any specific area of the project related to this PR?
/area build
/area CI
/area driver-bpf
/area libscap-engine-bpf
/area libscap
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
/version driver-API-version-major
What this PR does / why we need it:
Falco 0.43.0 deprecated the legacy eBPF probe as approved in https://github.com/falcosecurity/falco/blob/0.43.0/proposals/20251215-legacy-bpf-grpc-output-gvisor-engine-deprecation.md, and the support will be removed soon in the next libs release. This PR drops any reference to it and any CI tests testing it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone 0.24.0
Does this PR introduce a user-facing change?: