Skip to content

chore(driver/modern_bpf): add v6.19.7 to bpf validator config#2908

Open
ekoops wants to merge 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/vng-6.19
Open

chore(driver/modern_bpf): add v6.19.7 to bpf validator config#2908
ekoops wants to merge 1 commit intofalcosecurity:masterfrom
ekoops:ekoops/vng-6.19

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Mar 18, 2026

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-modern-bpf

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.24.0

Does this PR introduce a user-facing change?:

NONE

@poiana poiana added release-note-none kind/test PRs increasing the test coverage without fixing any failing test labels Mar 18, 2026
@poiana poiana added this to the 0.24.0 milestone Mar 18, 2026
@poiana poiana requested review from hbrueckner and terror96 March 18, 2026 08:22
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

Perf diff from master - unit tests

     8.47%     -0.63%  [.] sinsp_threadinfo::get_fd_table()
    12.89%     -0.63%  [.] sinsp_threadinfo::get_main_thread()
     9.89%     +0.53%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     6.63%     +0.41%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     4.31%     -0.37%  [.] thread_group_info::get_first_thread() const
    15.79%     +0.30%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     9.37%     +0.28%  [.] sinsp_threadinfo::update_main_fdtable()
     0.23%     -0.19%  [.] sinsp_parser::parse_clone_exit_child(sinsp_evt&, sinsp_parser_verdict&) const
     0.27%     -0.11%  [.] sinsp_utils::find_longest_matching_evt_param(std::basic_string_view<char, std::char_traits<char> >)
    13.58%     -0.10%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0012         -0.0013           236           236           236           235
BM_sinsp_split_median                                          -0.0042         -0.0038           236           235           236           235
BM_sinsp_split_stddev                                          -0.3116         -0.3344             2             1             2             1
BM_sinsp_split_cv                                              -0.3107         -0.3335             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0425         +0.0425            70            73            70            73
BM_sinsp_concatenate_paths_relative_path_median                +0.0461         +0.0460            69            73            69            73
BM_sinsp_concatenate_paths_relative_path_stddev                +1.2256         +1.2445             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.1348         +1.1531             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0184         -0.0185            42            42            42            42
BM_sinsp_concatenate_paths_empty_path_median                   -0.0032         -0.0032            42            42            42            42
BM_sinsp_concatenate_paths_empty_path_stddev                   +8.0797         +8.1328             0             1             0             1
BM_sinsp_concatenate_paths_empty_path_cv                       +8.2503         +8.3048             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0011         +0.0010            69            69            69            69
BM_sinsp_concatenate_paths_absolute_path_median                +0.0016         +0.0015            69            69            69            69
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.3644         +1.3718             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.3619         +1.3693             0             0             0             0

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.31%. Comparing base (2b71e52) to head (40b7c67).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2908   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files         295      295           
  Lines       31310    31310           
  Branches     4925     4925           
=======================================
  Hits        23582    23582           
  Misses       7728     7728           
Flag Coverage Δ
libsinsp 75.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

terror96
terror96 previously approved these changes Mar 18, 2026
Copy link
Contributor

@terror96 terror96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, terror96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terror96
Copy link
Contributor

/hold

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@terror96 terror96 removed the lgtm label Mar 18, 2026
@terror96
Copy link
Contributor

/lgtm

I removed the tag. Sorry for not waiting the tests to pass before stamping. :(

@ekoops
Copy link
Contributor Author

ekoops commented Mar 18, 2026

/lgtm

I removed the tag. Sorry for not waiting the tests to pass before stamping. :(

Yeah, no sissue 💪 . I'll come to this when I have some time 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants