Skip to content

Conversation

@deepskyblue86
Copy link
Member

What type of PR is this?
/kind documentation

Any specific area of the project related to this PR?
/area plugins
/area documentation

What this PR does / why we need it:
Have an OWNERS file for the container plugin. I'm proposing this list from

❯ git log --pretty=%aN . | sort | uniq -c | sort -nr
     53 Federico Di Pierro
     14 Leonardo Grasso
     14 Angelo Puglisi
     11 Iacopo Rozzo
      9 dependabot[bot]
      6 Klaus Wagner
      5 Leonardo Di Giovanna
      1 Roberto Scolaro
      1 Luca Guerra

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Rules files suggestions

@leogr
Copy link
Member

leogr commented Dec 12, 2025

/hold until vote completes

@leogr leogr changed the title docs(plugins/container): add OWNERS file vote: docs(plugins/container): add OWNERS file Dec 12, 2025
leogr

This comment was marked as duplicate.

@leogr
Copy link
Member

leogr commented Dec 12, 2025

+1 from me, assuming @deepskyblue86 is just proposing himself, and we are voting on his addition.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People must propose themselves to become maintainers. Existing maintainers must then vote on the proposal. See https://github.com/falcosecurity/evolution/blob/main/MAINTAINERS_GUIDELINES.md#onboarding-a-maintainer
So, if you want to add multiple people, please ask them to propose themselves.

Moreover, we should avoid adding a person (i.e., me) who is already a maintainer of the repository

@github-actions
Copy link

Rules files suggestions

@deepskyblue86 deepskyblue86 requested a review from leogr December 12, 2025 16:47
@leogr
Copy link
Member

leogr commented Dec 17, 2025

cc @falcosecurity/plugins-maintainers

@ekoops
Copy link
Contributor

ekoops commented Dec 19, 2025

Oh, I forgot to vote. +1 from me as well! 😄

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since more than one week passed and we have more votes in favor than against, the vote can be considered passed!

🥳

/approve

@poiana poiana added the lgtm label Dec 22, 2025
@poiana
Copy link
Contributor

poiana commented Dec 22, 2025

LGTM label has been added.

DetailsGit tree hash: 254310f83e5e660f28fecdcadd3228982937dd56

@poiana
Copy link
Contributor

poiana commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Dec 22, 2025

/remove-hold

@poiana poiana merged commit 3352cc2 into falcosecurity:main Dec 22, 2025
24 checks passed
@deepskyblue86 deepskyblue86 deleted the container-owners branch December 23, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants