-
Notifications
You must be signed in to change notification settings - Fork 99
vote: docs(plugins/container): add OWNERS file #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7524436 to
8080482
Compare
Rules files suggestions |
|
/hold until vote completes |
|
+1 from me, assuming @deepskyblue86 is just proposing himself, and we are voting on his addition. |
leogr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People must propose themselves to become maintainers. Existing maintainers must then vote on the proposal. See https://github.com/falcosecurity/evolution/blob/main/MAINTAINERS_GUIDELINES.md#onboarding-a-maintainer
So, if you want to add multiple people, please ask them to propose themselves.
Moreover, we should avoid adding a person (i.e., me) who is already a maintainer of the repository
Signed-off-by: Angelo Puglisi <[email protected]>
8080482 to
5be1e33
Compare
Rules files suggestions |
|
cc @falcosecurity/plugins-maintainers |
|
Oh, I forgot to vote. +1 from me as well! 😄 |
leogr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since more than one week passed and we have more votes in favor than against, the vote can be considered passed!
🥳
/approve
|
LGTM label has been added. DetailsGit tree hash: 254310f83e5e660f28fecdcadd3228982937dd56 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepskyblue86, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/remove-hold |
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area plugins
/area documentation
What this PR does / why we need it:
Have an OWNERS file for the container plugin. I'm proposing this list from
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: