feat(plugins/container): cache resolution results#1178
Merged
poiana merged 1 commit intofalcosecurity:mainfrom Jan 28, 2026
Merged
feat(plugins/container): cache resolution results#1178poiana merged 1 commit intofalcosecurity:mainfrom
poiana merged 1 commit intofalcosecurity:mainfrom
Conversation
therealbobo
force-pushed
the
container-perf
branch
3 times, most recently
from
f4ee1dc to
2ba9c5c
Compare
irozzo-1A
changed the title
irozzo-1A
reviewed
Jan 27, 2026
Contributor
irozzo-1A
left a comment
irozzo-1A
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for this! You just forgot adding the LRU test to CMake
Contributor
|
This should fix the failing CI job |
therealbobo
force-pushed
the
container-perf
branch
from
2ba9c5c to
47cb687
Compare
Contributor
|
@therealbobo #1180 entered, after rebasing you should not have the CI failure any longer. Thanks! |
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
container-perf
branch
from
47cb687 to
5531fba
Compare
Rules files suggestions |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 8be07832ad58b7098255b1272aded96e10bbe8ab |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Adds an LRU cache to the container matcher to cache cgroup-to-container resolution results, reducing repeated lookups and improving performance.
The
match_cgroupmethod iterates through all configured container engines (Docker, Podman, CRI, Containerd, etc.) to resolve acgrouppath to a container ID. The same cgroup paths can be resolved repeatedly, causing unnecessary work.Which issue(s) this PR fixes:
Fixes #1179
Special notes for your reviewer: