new(plugins/container): added fetcher tests.#723
Merged
poiana merged 1 commit intofalcosecurity:mainfrom Apr 17, 2025
Merged
Conversation
poiana
added
kind/bug
FedeDP
force-pushed
the
new/container_pl_fetcher_tests
branch
3 times, most recently
from
d087689 to
ce11d31
Compare
Rules files suggestions |
FedeDP
commented
Apr 17, 2025
|
|
||
| func (c *criEngine) get(ctx context.Context, containerId string) (*event.Event, error) { | ||
| ctrs, err := c.client.ListContainers(ctx, &v1.ContainerFilter{State: &v1.ContainerStateValue{}, Id: containerId}) | ||
| ctrs, err := c.client.ListContainers(ctx, &v1.ContainerFilter{Id: containerId}) |
Also, fixed a small bug in cri engine `get()` method. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
new/container_pl_fetcher_tests
branch
from
ce11d31 to
562ffc4
Compare
Rules files suggestions |
leogr
approved these changes
Apr 17, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Also, fixed a small bug in cri engine
get()method.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: