update(plugins/container): updated container plugin to 0.2.2#759
Merged
poiana merged 3 commits intofalcosecurity:mainfrom May 6, 2025
Merged
update(plugins/container): updated container plugin to 0.2.2#759poiana merged 3 commits intofalcosecurity:mainfrom
poiana merged 3 commits intofalcosecurity:mainfrom
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
commented
May 6, 2025
Rules files suggestions |
1 similar comment
Rules files suggestions |
…gin e2e tests. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Contributor
Author
|
Will squash all wip commits, and remove |
Rules files suggestions |
FedeDP
force-pushed
the
update/container_plugin_022
branch
2 times, most recently
from
32c6b6a to
edc16a9
Compare
Rules files suggestions |
FedeDP
force-pushed
the
update/container_plugin_022
branch
from
edc16a9 to
0ff53d0
Compare
Rules files suggestions |
FedeDP
force-pushed
the
update/container_plugin_022
branch
from
fa40db8 to
63d8b58
Compare
Contributor
Author
|
Reproducing the panic we saw this morning: I hoped #758 fixed the issue :/ well, at least we now have a way to see it in this CI, that should be helpful. |
Rules files suggestions |
Since the c string comes from a stack variable `.c_str()`, and the go string will be used async, `ptr.GoString()` does not guarantee that the string is kept alive for all its duration, leading to bogus reads. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
update/container_plugin_022
branch
from
3806723 to
e9685a4
Compare
Rules files suggestions |
FedeDP
changed the title
FedeDP
commented
May 6, 2025
| //export AskForContainerInfo | ||
| func AskForContainerInfo(containerId *C.cchar_t) { | ||
| containerID := ptr.GoString(unsafe.Pointer(containerId)) | ||
| containerID := C.GoString(containerId) |
leogr
approved these changes
May 6, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Also, properly use reusable workflow provided by libs to run container e2e tests.
Finally, avoid using
ptr.GoStringinAskForContainerInfosince the string we use as go string internal data is just stack allocated with.c_str()and will be pretty dead soon (consideringFetcherruns async).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Keeping this
wipuntil falcosecurity/libs#2390 is merged.