fix(plugins/container): redefine port binding port and IP as integers#822
Merged
poiana merged 1 commit intofalcosecurity:mainfrom Jun 3, 2025
Merged
Conversation
leogr
reviewed
Jun 3, 2025
Member
leogr
left a comment
leogr
left a comment
There was a problem hiding this comment.
Can you bump the plugin version too?
🙏
Rules files suggestions |
ekoops
force-pushed
the
ekoops/fix-port-binding
branch
from
77084db to
482eef0
Compare
Rules files suggestions |
FedeDP
reviewed
Jun 3, 2025
FedeDP
reviewed
Jun 3, 2025
Contributor
Author
|
Ok I'm gonna apply your suggestion and come back soon 😄 |
ekoops
force-pushed
the
ekoops/fix-port-binding
branch
from
482eef0 to
fd5f7c4
Compare
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
ekoops
force-pushed
the
ekoops/fix-port-binding
branch
from
fd5f7c4 to
8eb89f8
Compare
Contributor
|
Changes LGTM! |
Rules files suggestions |
leogr
approved these changes
Jun 3, 2025
Contributor
|
LGTM label has been added. DetailsGit tree hash: 1fe2c705b814ad42e169593ffe24b3a71d68053e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
This PR redefines port binding's port and IP as integers.
Which issue(s) this PR fixes:
Fixes #814
Special notes for your reviewer: