Skip to content

chore(ci,plugins/container): use -tags containers_image_openpgp for test make target too #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poiana merged 2 commits into from
Jun 3, 2025
Merged

chore(ci,plugins/container): use -tags containers_image_openpgp for test make target too #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19e8dcf
chore(ci,plugins/container): use `-tags containers_image_openpgp ` fo…
FedeDP Jun 3, 2025
7b60103
fx(plugins/container): do not override containers_image_openpgp tag i…
FedeDP Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/container-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,8 @@ jobs:
arch: [ amd64, arm64 ]
steps:
# libbtrfs: needed by podman package - build dep.
# libgpgme: needed by github.com/containers/image, build dep since our go build tags use opengpg instead.
- name: Install go test deps
run: sudo apt-get install -y --no-install-recommends libbtrfs-dev libgpgme-dev
run: sudo apt-get install -y --no-install-recommends libbtrfs-dev

- name: Checkout repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down
4 changes: 2 additions & 2 deletions plugins/container/go-worker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ lib:

.PHONY: exe
exe:
CGO_ENABLED=1 go build -tags containers_image_openpgp -ldflags="-s -w" -tags exe -v -o worker .
CGO_ENABLED=1 go build -ldflags="-s -w" -tags exe,containers_image_openpgp -v -o worker .

clean:
rm -rf worker libworker.a libworker.h

.PHONY: test
test:
go clean -testcache
GOEXPERIMENT=loopvar go test -v -cover -race ./...
GOEXPERIMENT=loopvar go test -tags containers_image_openpgp -v -cover -race ./...
Loading