Add error handling for cri and podman engines when container events are disabled and go-channels are closed early - also add retry logic in fetcher channel to prevent missing container info due to timing issues with cri engine

[nenioscio]

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

1. For the engines podman and cri a possible error on event listener setup is not captured leading to and endless loop reading from a closed socket - this causes high CPU load
2. For the cri engine a timing issue prevents reading the container info - workaround: add a retry loop for a fixed duration
3. Enhance interaction between c++ and go when AskForContainerInfo is called by making the channel buffered

Which issue(s) this PR fixes:
Fixes

Fixes falcosecurity/falco#3610 and falcosecurity/falco#3630

Special notes for your reviewer:

@FedeDP : this pull request is based new commit on top of already discussed commit 28cb4d4 which already include the changes you requested via inline comments

[FedeDP]

Thank you very much, doing the codereview now! :)

[FedeDP]

All in all, a bunch of great fixes and improvements to make container plugin more reliable.
I already shared my huge appreciation on falcosecurity/falco#3610, but let me share it too :) Thank you very much for your great work!

I left some suggestions/small things to improve, but all in all this is looking really good!

[FedeDP]

Oh and it seems that we also broke podman tests somewhere :)

[github-actions]

Rules files suggestions

[FedeDP]

/hold

[github-actions]

Rules files suggestions

[github-actions]

Rules files suggestions

[nenioscio]

Oh and it seems that we also broke podman tests somewhere :)

I managed to fix this -

"system.Events" yields nil on successful init so I ignore it when the error side-channel is processed

[github-actions]

Rules files suggestions

[FedeDP]

Changes LGTM!
We can further optimize the way we kill goroutines dynamically from workerLoop, but aside from that (that should be a corner case of a corner case btw), everything looks good!
/approve

[poiana]

LGTM label has been added.

Details

Git tree hash: a514d8f94d579725020df8709ef6abdc32923a7a

[FedeDP]

/unhold

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP, nenioscio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ekoops]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment