Draft
Conversation
false-spring
force-pushed
the
feat/item-drop-tracking
branch
from
244eba9 to
155cb34
Compare
false-spring
force-pushed
the
feat/item-drop-tracking
branch
from
155cb34 to
08b9ab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to track item drops from quests.
PR is on hold, as the timing that the parser uses to save the parser log is when quest completed. However, items get dropped after the "quest completion" hook is fired. Need to rework the save timing so that we save the parsed log with the dropped items in one go, or save the quest twice when we receive the items.