fix(features): Allow all feature subsets to compile #32
Conversation
A half-applied suggestion from review during the release PR in #31 broke features that depend on serde.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 64.02% 64.02%
=======================================
Files 6 6
Lines 378 378
=======================================
Hits 242 242
Misses 136 136
Continue to review full report in Codecov by Sentry.
|
| config = ["dep:figment", "dep:serde"] | ||
| level_filter = ["dep:tracing", "dep:serde"] | ||
| config = ["dep:figment", "serde"] | ||
| level_filter = ["dep:tracing"] |
There was a problem hiding this comment.
LevelFilter is useless without serde, featuregating whole crate::level_filter with serde seems like a good idea. Can you clarify what is broken? Maybe an example of a feature set that fails to compile?
There was a problem hiding this comment.
It's been 3 months :D I think the FromStr and Fmt impls were still useful, at least in tests somewhere. I'll see if I can dig up the reasoning again, but I'm unsure I'll find it. I did consider this, I swear, not including serde was a conscious decision - wish I'd left a comment.
A half-applied suggestion from review during the release PR in #31 broke features that depend on serde. Since we have to fix this anyway, might as well go all the way and set features to depend on each other, and boot serde wherever possible.