Skip to content

Conversation

@sirewix
Copy link
Contributor

@sirewix sirewix commented Aug 1, 2025

Closes #33

@sirewix sirewix requested a review from a team as a code owner August 1, 2025 16:07
@sirewix sirewix force-pushed the sirewix/some-features branch 2 times, most recently from dde6c48 to 56c5bc3 Compare August 4, 2025 11:18
@sirewix sirewix force-pushed the sirewix/some-features branch from 56c5bc3 to f7e2f1b Compare August 4, 2025 11:23
Copy link
Contributor

@mzaniolo mzaniolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Have you seen the crate humantime_serde. It seems to do something similar to what we are doing with the duration

@sirewix
Copy link
Contributor Author

sirewix commented Aug 6, 2025

It looks good to me.
Have you seen the crate humantime_serde. It seems to do something similar to what we are doing with the duration

It's better to have it as a type and not a "return type of function inside a module specified in serde_with macro attribute". Such typefulness allows to have proper json schema definitions, for example

@sirewix sirewix merged commit f7e2f1b into main Aug 6, 2025
5 checks passed
@sirewix sirewix deleted the sirewix/some-features branch August 6, 2025 05:22
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.89%. Comparing base (156dd93) to head (f7e2f1b).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/lib.rs 0.00% 27 Missing ⚠️
src/level_filter.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   61.27%   67.89%   +6.62%     
==========================================
  Files           6        6              
  Lines         346      380      +34     
==========================================
+ Hits          212      258      +46     
+ Misses        134      122      -12     
Files with missing lines Coverage Δ
src/duration.rs 84.69% <100.00%> (+39.01%) ⬆️
src/level_filter.rs 68.08% <0.00%> (+11.94%) ⬆️
src/lib.rs 64.55% <0.00%> (-33.52%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156dd93...f7e2f1b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing default in schemas for some for serde wrappers

3 participants