refactor: Migrate to js interop #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krille-chan
force-pushed
the
krille/migrate-to-js-interop
branch
3 times, most recently
from
416ce31 to
b331a50
Compare
rmoradi88
requested changes
Dec 27, 2025
.dart_tool/package_config.json
Outdated
| "packages": [ | ||
| { | ||
| "name": "args", | ||
| "rootUri": "file:///Users/christianpauly/.pub-cache/hosted/pub.dev/args-2.7.0", |
Contributor
Author
There was a problem hiding this comment.
Yes .dart_tool should be in .gitignore. I've added it
lib/src/web.dart
Outdated
| setTabs(name, getTabs(name) + 1); | ||
|
|
||
| window.onUnload.listen((_) { | ||
| void onunloadCallback(web.Event event) { |
krille-chan
force-pushed
the
krille/migrate-to-js-interop
branch
from
b331a50 to
4442394
Compare
rmoradi88
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.