feat: implement retry encryption key request mechanism for livekit calls #2207
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
==========================================
+ Coverage 57.54% 57.97% +0.42%
==========================================
Files 153 153
Lines 19485 19505 +20
==========================================
+ Hits 11213 11308 +95
+ Misses 8272 8197 -75
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
coder-with-a-bushido
force-pushed
the
karthi/retry-keys
branch
from
75a7cd2 to
d7c135a
Compare
coder-with-a-bushido
force-pushed
the
karthi/retry-keys
branch
2 times, most recently
from
25886b1 to
8a528b9
Compare
coder-with-a-bushido
force-pushed
the
karthi/retry-keys
branch
from
8a528b9 to
3e978f9
Compare
| deviceId: deviceId, | ||
| ); | ||
|
|
||
| // Cancel any pending retry for this participant since we received keys |
There was a problem hiding this comment.
How does this fix the issue mentioned in https://github.com/famedly/product-management/issues/2078? They might send us keys for index N+1 but never start using it, we should only cancel requests when we get a answer for the requested index
There was a problem hiding this comment.
My bad, I misread the issue! thank you
There was a problem hiding this comment.
Will work on it now
| _requestEncryptionKeyPending.remove(rp); | ||
| return; | ||
| } | ||
| unawaited(requestEncrytionKey(groupCall, [rp])); |
There was a problem hiding this comment.
any reason this is unawaited?
Pull request was converted to draft
Closes https://github.com/famedly/product-management/issues/2097
Closes https://github.com/famedly/product-management/issues/2078