Skip to content

Conversation

@krille-chan
Copy link
Contributor

@krille-chan krille-chan commented Dec 31, 2025

closes https://github.com/famedly/product-management/issues/3493

I think it makes sense to still keep the Bootstrap class but offer a simplified API on top of it. The Bootstrap object with it's state makes sure that we do never run into a broken state (in theory) and some consumers might still want to use it.

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 75.29412% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.80%. Comparing base (7fd01a9) to head (c5e96b9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/encryption/utils/crypto_setup_extension.dart 75.29% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
+ Coverage   57.67%   57.80%   +0.13%     
==========================================
  Files         157      158       +1     
  Lines       19592    19677      +85     
==========================================
+ Hits        11299    11375      +76     
- Misses       8293     8302       +9     
Files with missing lines Coverage Δ
lib/encryption/utils/crypto_setup_extension.dart 75.29% <75.29%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd01a9...c5e96b9. Read the comment docs.

@krille-chan krille-chan force-pushed the krille/simplified-bootstrap branch 7 times, most recently from 36c7d20 to 68529c4 Compare December 31, 2025 09:50
@krille-chan krille-chan marked this pull request as ready for review December 31, 2025 09:52
@krille-chan krille-chan force-pushed the krille/simplified-bootstrap branch 2 times, most recently from bd5a8bf to a93b49c Compare January 9, 2026 12:52
@krille-chan krille-chan force-pushed the krille/simplified-bootstrap branch 9 times, most recently from e55817f to f0abdc7 Compare January 16, 2026 14:09
@Yash-Garg Yash-Garg self-requested a review January 19, 2026 10:14
Copy link
Member

@td-famedly td-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from that lgtm!

@krille-chan krille-chan force-pushed the krille/simplified-bootstrap branch from f0abdc7 to 1ebc7cd Compare January 20, 2026 08:46
@krille-chan krille-chan force-pushed the krille/simplified-bootstrap branch from 1ebc7cd to c5e96b9 Compare January 20, 2026 08:48
@krille-chan krille-chan enabled auto-merge January 20, 2026 08:48
@krille-chan krille-chan merged commit d5a9c12 into main Jan 20, 2026
26 of 27 checks passed
@krille-chan krille-chan deleted the krille/simplified-bootstrap branch January 20, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants