Updated client.go with newer wapi version 2.7.3#35
Updated client.go with newer wapi version 2.7.3#35rudhron wants to merge 1 commit intofanatic:masterfrom
Conversation
|
Thanks for the change! For the reasons I outlined over in #33, I'm hesitant to merge this until I we can verify that it maintains backwards compatibility for the folks using this library today. The infoblox I have access to is still on the much older wapi version, and merging this pull request would break that. Perhaps it can be configurable? |
|
Thanks for reaching out Jason! Yes if it breaks your code please don't
commit it. I have cloned your repo but am unable to build the binary. Do
you have any specific deps for the build?
On Sun, Jul 1, 2018 at 14:08 Jason Parrott ***@***.***> wrote:
Thanks for the change! For the reasons I outlined over in #33
<#33>, I'm hesitant to merge
this until I we can verify that it maintains backwards compatibility for
the folks using this library today. The infoblox I have access to is still
on the much older wapi version, and merging this pull request would break
that. Perhaps it can be configurable?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ad0Ewwfoh_ePmZv6yJMwO9XOlsoTmCkMks5uCTo3gaJpZM4U9ge7>
.
--
Regards, Prithviraj Jathan
|
|
You should be able to run |
|
I have an immediate need to use the newer version WAPI, for example: vs But rather than waiting for an extensive regression test in order to support |
No description provided.