Skip to content

Set stdout encoding to something byte-friendly when using bytes - #994

Merged
alex9849 merged 3 commits into
mainfrom
fix/stdout-encoding
Aug 13, 2026
Merged

Set stdout encoding to something byte-friendly when using bytes#994
alex9849 merged 3 commits into
mainfrom
fix/stdout-encoding

Conversation

@riesentoaster

Copy link
Copy Markdown
Collaborator

What and why

Fixes #690

Description of the problem see issue

How was it tested?

Added unit tests

Checklist

  • Does one thing, and the diff is limited to what that needs
  • Tests cover any changed behaviour
  • Docs updated, if this changes something a user can see
  • pre-commit and make tests pass locally
  • make lock was run, if pyproject.toml dependencies changed
  • I understand what every changed line does and why it is there
  • I wrote this description myself, and said above if the change was
    substantially AI-assisted

@riesentoaster
riesentoaster requested a review from alex9849 August 13, 2026 11:48
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Projectfandango
Branchfix/stdout-encoding
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
tests/test_benchmarks.py::test_generate_with_single_hard_constraint📈 view plot
🚷 view threshold
1,634.04 ms
(-12.96%)Baseline: 1,877.36 ms
2,188.88 ms
(74.65%)
tests/test_benchmarks.py::test_generate_with_single_soft_constraint📈 view plot
🚷 view threshold
76,950.28 ms
(+40.27%)Baseline: 54,859.76 ms
89,482.60 ms
(85.99%)
tests/test_benchmarks.py::test_init_fandango📈 view plot
🚷 view threshold
162.43 ms
(+7.12%)Baseline: 151.64 ms
168.88 ms
(96.18%)
tests/test_benchmarks.py::test_parse_spec📈 view plot
🚷 view threshold
162.52 ms
(+6.42%)Baseline: 152.71 ms
169.07 ms
(96.13%)
🐰 View full continuous benchmarking report in Bencher

@alex9849 alex9849 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command line looks good for me, however, there are unit tests related to output dumping that are failing now.

@riesentoaster

Copy link
Copy Markdown
Collaborator Author

Already on it.

I redacted dislike Windows.

Comment thread src/fandango/cli/output.py Fixed
Comment thread src/fandango/cli/output.py Dismissed
@alex9849
alex9849 merged commit db41490 into main Aug 13, 2026
57 of 63 checks passed
@alex9849
alex9849 deleted the fix/stdout-encoding branch August 13, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fandango sometimes produces incorrect outputs

2 participants