Set stdout encoding to something byte-friendly when using bytes - #994
Merged
Conversation
|
| Project | fandango |
| Branch | fix/stdout-encoding |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| tests/test_benchmarks.py::test_generate_with_single_hard_constraint | 📈 view plot 🚷 view threshold | 1,634.04 ms(-12.96%)Baseline: 1,877.36 ms | 2,188.88 ms (74.65%) |
| tests/test_benchmarks.py::test_generate_with_single_soft_constraint | 📈 view plot 🚷 view threshold | 76,950.28 ms(+40.27%)Baseline: 54,859.76 ms | 89,482.60 ms (85.99%) |
| tests/test_benchmarks.py::test_init_fandango | 📈 view plot 🚷 view threshold | 162.43 ms(+7.12%)Baseline: 151.64 ms | 168.88 ms (96.18%) |
| tests/test_benchmarks.py::test_parse_spec | 📈 view plot 🚷 view threshold | 162.52 ms(+6.42%)Baseline: 152.71 ms | 169.07 ms (96.13%) |
alex9849
requested changes
Aug 13, 2026
alex9849
left a comment
Collaborator
There was a problem hiding this comment.
The command line looks good for me, however, there are unit tests related to output dumping that are failing now.
Collaborator
Author
|
Already on it. I redacted dislike Windows. |
alex9849
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes #690
Description of the problem see issue
How was it tested?
Added unit tests
Checklist
pre-commitandmake testspass locallymake lockwas run, ifpyproject.tomldependencies changedsubstantially AI-assisted