fix: allow month 0 to focus initial month#235
Open
Darcyu83 wants to merge 1 commit intofarhoudshapouran:mainfrom
Open
fix: allow month 0 to focus initial month#235Darcyu83 wants to merge 1 commit intofarhoudshapouran:mainfrom
Darcyu83 wants to merge 1 commit intofarhoudshapouran:mainfrom
Conversation
Allow month=0 to be applied when setting the initial focused month.
|
Could you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow
month=0to be applied when setting the initial focused month.Why
When opening the calendar, the focused month could not be set to January (0) because the check treated 0 as falsy.
How
Use a numeric check for
monthso 0 is allowed.