feat: add customizable accessibility labels for prev/next navigation buttons#242
Open
jvilliers wants to merge 5 commits intofarhoudshapouran:mainfrom
Open
feat: add customizable accessibility labels for prev/next navigation buttons#242jvilliers wants to merge 5 commits intofarhoudshapouran:mainfrom
jvilliers wants to merge 5 commits intofarhoudshapouran:mainfrom
Conversation
feat: fix onChangeMonth function
…ear_when_month_is_updated feat(selectYear): trigger onSelectYear when month is updating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prevButtonAccessibilityLabel and nextButtonAccessibilityLabel props to DatePickerBaseProps, allowing consumers to override the default "Prev" / "Next" accessibility labels on the calendar navigation buttons.
This is useful for apps that need localized or context-specific accessibility labels to comply with screen reader requirements.
Changes:
types.ts — add prevButtonAccessibilityLabel?: string and nextButtonAccessibilityLabel?: string to DatePickerBaseProps
datetime-picker.tsx — forward both props through the calendar context value
prev-button.tsx — consume prevButtonAccessibilityLabel from context (default: 'Prev')
next-button.tsx — consume nextButtonAccessibilityLabel from context (default: 'Next')