Skip to content

Refactor Schema utility functions such as omit, pick, and partial to preserve the recursive capability of ObjectType, while adding a required utility function. #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lucifier129 merged 2 commits into from
Jan 20, 2025
Merged

Refactor Schema utility functions such as omit, pick, and partial to preserve the recursive capability of ObjectType, while adding a required utility function. #198

Lucifier129 merged 2 commits into from
Jan 20, 2025

Conversation

@AisonSu
Copy link
Contributor

@AisonSu AisonSu commented Jan 15, 2025

Refactor Schema utility functions such as omit, pick, and partial to preserve the recursive capability of ObjectType, while adding a required utility function.

@AisonSu
refactor(farrow-schema): enhance Utilities with pick, omit, partial, …
4250c35 
…and required functionalities with preserve the recursive capability of ObjectType
Lucifier129
Lucifier129 reviewed Jan 16, 2025
View reviewed changes
Lucifier129
Lucifier129 reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@Lucifier129 Lucifier129 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test-cases for this change, especially for formatter/validator.

@AisonSu
test(farrow-schema): Based on the test results, some problematic code…
8ecf09b 
… has been modified, and relevant tests for the required utility function have been added.
@AisonSu
Copy link
Contributor Author

AisonSu commented Jan 18, 2025

Please add some test-cases for this change, especially for formatter/validator.

Thanks for the reminder! I've already added test cases for the formatter and validator, and all tests have passed successfully. Let me know if you need any further adjustments or additional test coverage.

@Lucifier129
Copy link
Collaborator

Lucifier129 commented Jan 20, 2025

LGTM

@Lucifier129 Lucifier129 merged commit e0dbc06 into farrow-js:master Jan 20, 2025
@Lucifier129
Copy link
Collaborator

Lucifier129 commented Jan 20, 2025

farrow-schema v2.3.3 has been published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lucifier129 Lucifier129 Lucifier129 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AisonSu @Lucifier129