Merged
Conversation
Improve test coverage by adding tests for previously untested or under-tested modules: - test_assertions.py: 30+ tests for cryptographic signing and JSON Lines output - test_schema_comprehensive.py: 33 tests for XSD/RELAX NG validation - test_engine_wrapper.py: 20 tests for engine integration (100% passing) - test_cli_new.py: 39 tests for modern Typer CLI Source code fixes discovered through testing: - Add metadata field to ValidationResult for schema validation - Add contraction_operator and projection_operator helper functions - Add ProofGenerator class for CLI proof commands These tests reveal several source code bugs that need attention: - XSD derivation incorrectly handles XML namespaces - RELAX NG caching fails due to unpicklable objects - Typer version compatibility issues in CLI
- Fix ConvergenceResult API usage in cli_new.py (use is_converged(), metrics.iterations) - Fix XSD derivation namespace handling in schema.py (use nsmap instead of attrib) - Fix RELAX NG cache TypeError handling in cache.py - Update Typer version constraint to support >=0.9.0 in pyproject.toml - Update CLI schema derive command to accept string argument for Typer compatibility - Update test expectations to match corrected API All 615 tests now pass.
These files are generated during test runs and should be ignored.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.