Fix parsing when element is between buffers#1
Open
hanneskuettner wants to merge 1 commit intofaruktoptas:masterfrom
Open
Fix parsing when element is between buffers#1hanneskuettner wants to merge 1 commit intofaruktoptas:masterfrom
hanneskuettner wants to merge 1 commit intofaruktoptas:masterfrom
Conversation
Owner
|
Thank you for your contribution. Can you provide a Rss URL or a sample Xml please? I will create a unit test for this. |
Author
|
Sure thing! |
Owner
|
This works but when try to parse this xml: |
Author
|
I will look into that. |
Owner
|
I will add more samples. Now I am working on unit testing. It is almost done. |
Owner
|
I added unit tests to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the characters method in the XMLParser is called with element text that is cut in half due to the buffer size of the underlying parser.
We cannot stop looking at the value that we are interested in after we got the first value, but rather until we encounter the end tag for this element.