Skip to content

Conversation

@ztc0611
Copy link

@ztc0611 ztc0611 commented Apr 15, 2025

I feel like having it just match the theme of the rest of macOS makes more sense and matches the minimalism. This is nice especially for people who use Auto instead of having their computer fixed in Light or Dark.

Note for testing:
macOS 15.4 seems to have buggy behavior with theme switch animations, but when testing it on 15.0.1 it works with the default fade animation as expected. Not sure about .1/.2/.3.

@quiint
Copy link

quiint commented Apr 17, 2025

works on my machine (15.5 Beta 24F5053f)
i don't see the animation, but the theme switches! this could be useful, but i also think it would be good to keep the theme switcher icon just in case this doesn't match the specific users preferences. other than that, looks good to me - thanks for contributing!

@farzaa
Copy link
Owner

farzaa commented Apr 18, 2025

i like the change, but, lets keep the button.

pulling from their system is fine on initial load lets keep that

@ztc0611
Copy link
Author

ztc0611 commented Apr 18, 2025

i like the change, but, lets keep the button.

pulling from their system is fine on initial load lets keep that

So have 3 button states, light/dark/automatic, or open in automatic with the option to switch?

@ztc0611
Copy link
Author

ztc0611 commented Apr 18, 2025

works on my machine (15.5 Beta 24F5053f) i don't see the animation, but the theme switches! this could be useful, but i also think it would be good to keep the theme switcher icon just in case this doesn't match the specific users preferences. other than that, looks good to me - thanks for contributing!

It appears to me like it was broken universally on macOS 15.4. Both macs I have access to don’t exhibit light → dark mode animation on any app I have open even ones that absolutely did on earlier versions of 15 (and <15).

@ztc0611
Copy link
Author

ztc0611 commented Apr 18, 2025

I pushed a squashed, improved version with the options of light, dark, and auto in a popover menu. let me know what you think :)

If anybody knows how to fix the issue where clicking between the icon and the text causes it to not trigger the effect, please advise. I can't quite figure that one out. Besides that, should work.

@ztc0611 ztc0611 force-pushed the dark-mode-fix branch 4 times, most recently from b46b419 to 558ea82 Compare April 18, 2025 04:08
@ztc0611
Copy link
Author

ztc0611 commented Apr 18, 2025

I think I fixed the animation now, too.

@ztc0611
Copy link
Author

ztc0611 commented Apr 21, 2025

I've tested it a bit over the past few days and I think it's working pretty well. There might be some edge cases I failed to find though.

@ztc0611 ztc0611 changed the title Make Dark Mode Automatic Add Automatic Dark Mode option Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants