-
Notifications
You must be signed in to change notification settings - Fork 215
Add Automatic Dark Mode option #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
works on my machine (15.5 Beta 24F5053f) |
|
i like the change, but, lets keep the button. pulling from their system is fine on initial load lets keep that |
So have 3 button states, light/dark/automatic, or open in automatic with the option to switch? |
It appears to me like it was broken universally on macOS 15.4. Both macs I have access to don’t exhibit light → dark mode animation on any app I have open even ones that absolutely did on earlier versions of 15 (and <15). |
|
I pushed a squashed, improved version with the options of light, dark, and auto in a popover menu. let me know what you think :) If anybody knows how to fix the issue where clicking between the icon and the text causes it to not trigger the effect, please advise. I can't quite figure that one out. Besides that, should work. |
b46b419 to
558ea82
Compare
|
I think I fixed the animation now, too. |
|
I've tested it a bit over the past few days and I think it's working pretty well. There might be some edge cases I failed to find though. |
I feel like having it just match the theme of the rest of macOS makes more sense and matches the minimalism. This is nice especially for people who use Auto instead of having their computer fixed in Light or Dark.
Note for testing:
macOS 15.4 seems to have buggy behavior with theme switch animations, but when testing it on 15.0.1 it works with the default fade animation as expected. Not sure about .1/.2/.3.