Skip to content

Conversation

@wu-clan
Copy link
Member

@wu-clan wu-clan commented Oct 18, 2025

此 PR 是 #829 的回归

  • 将 bool 类型直接作为模型列,而不再是 INTEGER
  • 简化 mysql 类型兼容性

@wu-clan
Copy link
Member Author

wu-clan commented Oct 18, 2025

这里涉及一个 sa.XXX 问题,切换主数据为 pg 时引入,原因有以下:

  • sa.xxx 代码直接从 SQLAlchemy 引入的类型具有主数据库(pg)兼容性
  • sa.xxx 可以更方便的进行类型选择(基于 IDE typing 提示),而无需猜测 sqla 类型命名进行导入
  • sa.xxx 与代码生成更加匹配,代码生成将兼容性类型通过 sa.xxx 进行导入,有助于简化 model 模板
  • sa.xxx 在网络上似乎应用非常广泛,并不会显得突兀

严重问题:

  • 非常不利于用户跟进升级,因为 sa. 必须手动一一 cv,保持原始非 sa.xxx 有助于用户升级操作

@wu-clan wu-clan requested a review from downdawn October 18, 2025 13:33
@wu-clan
Copy link
Member Author

wu-clan commented Oct 18, 2025

我们需要对以上内容说明做出决策

  • 引入 sa.xxx
  • 保持原始导入

@downdawn
Copy link
Collaborator

我们需要对以上内容说明做出决策

  • 引入 sa.xxx
  • 保持原始导入

改都改了,就统一sa吧

@wu-clan wu-clan merged commit e6e5329 into master Oct 20, 2025
5 checks passed
@wu-clan wu-clan deleted the optimize-SQLA-types branch October 20, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants