✨ Improve UI for fastapi dev and fastapi run
#95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick91
force-pushed
the
os/feature/new-dev-mode
branch
from
fb96fd6 to
bf2c972
Compare
Contributor
Author
|
There's a small issue when pressing CTRL+C:
you can see |
tiangolo
approved these changes
Dec 4, 2024
Member
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Awesome, thank you! This looks great, and the code much cleaner! 🚀
Ready the chicken 😎 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rich-toolkit to improve the look and feel of the app, for now we are only updating the server commands 😊
In terms of the code, I've most of the output out from the discover file into the main cli file (better to keep those utils simpler without any output)
Some potential improvements:
Better errors