-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
⚡️ Improve backend test performance by patching password hashing #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saltie2193
wants to merge
8
commits into
fastapi:master
Choose a base branch
from
saltie2193:backend-tests-performance-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−7
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
633880c
Improve backend test performance by patching password hashing
saltie2193 d37b84d
Use `contextlib.ExitStack` for managing multiple patchers
saltie2193 5e2bdf0
Make password hashing re-activatable
saltie2193 0fccbde
Simplify tests
YuriiMotov a6b477c
Fix lint errors
YuriiMotov 96d0296
Return back `autouse=True` for `db` fixture
YuriiMotov 471685b
Revert removal of `patch_password_hashing` utility
saltie2193 420b32a
Merge master into backend-test-performance-improvements
saltie2193 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import pytest | ||
from starlette.testclient import TestClient | ||
|
||
from app.core.config import settings | ||
|
||
pytestmark = pytest.mark.enable_password_hashing | ||
|
||
|
||
def test_get_access_token_with_hashing( | ||
client: TestClient, | ||
disable_password_hashing: bool, | ||
) -> None: | ||
assert disable_password_hashing is False | ||
login_data = { | ||
"username": settings.FIRST_SUPERUSER, | ||
"password": settings.FIRST_SUPERUSER_PASSWORD, | ||
} | ||
r = client.post(f"{settings.API_V1_STR}/login/access-token", data=login_data) | ||
tokens = r.json() | ||
assert r.status_code == 200 | ||
assert "access_token" in tokens | ||
assert tokens["access_token"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this style for docstrings in this project