Skip to content

Conversation

marcelomizuno
Copy link

Criadas as endpoints para gerenciamento dos tickets de atendimento.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file change should be removed from the commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the change with the alembic upgrade head should be mentioned.

I don't think this is something anybody wants on production that happens automatically.


# Ticket Enums
class TicketCategory(str, Enum):
SUPPORT = "Suporte"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values of this strings should be defined in language English to be in sync with the rest of the code base.

- DOMAIN=${DOMAIN}
- FRONTEND_HOST=${FRONTEND_HOST?Variable not set}
- ENVIRONMENT=${ENVIRONMENT}
- ENVIRONMENT=local

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you removed this option and replace it with a static value?

{ icon: FiHome, title: "Dashboard", path: "/" },
{ icon: FiBriefcase, title: "Items", path: "/items" },
{ icon: FiSettings, title: "User Settings", path: "/settings" },
{ icon: FiSettings, title: "Configurações do Usuário", path: "/settings" },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, language should be English to be in sync with the code base.

<Box pt={12} m={4}>
<Text>
<ul>
<ol><b>Página de Listagem de Tickets</b></ol>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, English language to be in sync with the rest of the code base.

@stevleibelt
Copy link

stevleibelt commented Apr 14, 2025

@marcelomizuno "Backend update" is not a great short description for what you've added.

Could you please explain what functionality your change tries to add and why this should be part of this template? Screenshots, if possible, are more than welcome.

@alejsdev
Copy link
Member

Hi @marcelomizuno, it seems this PR appears to have been intended for your fork rather than the main repository. We'll be closing this PR for now. Thank you! 🚀

@alejsdev alejsdev closed this Apr 14, 2025
@stevleibelt stevleibelt mentioned this pull request May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants