-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Backend update #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend update #1542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file change should be removed from the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least the change with the alembic upgrade head
should be mentioned.
I don't think this is something anybody wants on production that happens automatically.
|
||
# Ticket Enums | ||
class TicketCategory(str, Enum): | ||
SUPPORT = "Suporte" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values of this strings should be defined in language English to be in sync with the rest of the code base.
- DOMAIN=${DOMAIN} | ||
- FRONTEND_HOST=${FRONTEND_HOST?Variable not set} | ||
- ENVIRONMENT=${ENVIRONMENT} | ||
- ENVIRONMENT=local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you removed this option and replace it with a static value?
{ icon: FiHome, title: "Dashboard", path: "/" }, | ||
{ icon: FiBriefcase, title: "Items", path: "/items" }, | ||
{ icon: FiSettings, title: "User Settings", path: "/settings" }, | ||
{ icon: FiSettings, title: "Configurações do Usuário", path: "/settings" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, language should be English to be in sync with the code base.
<Box pt={12} m={4}> | ||
<Text> | ||
<ul> | ||
<ol><b>Página de Listagem de Tickets</b></ol> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, English language to be in sync with the rest of the code base.
@marcelomizuno "Backend update" is not a great short description for what you've added. Could you please explain what functionality your change tries to add and why this should be part of this template? Screenshots, if possible, are more than welcome. |
Hi @marcelomizuno, it seems this PR appears to have been intended for your fork rather than the main repository. We'll be closing this PR for now. Thank you! 🚀 |
Criadas as endpoints para gerenciamento dos tickets de atendimento.