Skip to content

🐛 Fix parse_cors function to be consistent for both empty string and empty list #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2025
Merged

🐛 Fix parse_cors function to be consistent for both empty string and empty list #1672

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cc1082
Fix the parse_cors function to be consistent for both empty string an…
rolkotaki Jun 15, 2025
ead5fa8
Merge branch 'master' into bugfix/parse-cors-function
rolkotaki Jul 21, 2025
e90d3a2
Update parse_cors function to work for edge case when nothing is prov…
rolkotaki Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/app/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

def parse_cors(v: Any) -> list[str] | str:
if isinstance(v, str) and not v.startswith("["):
if not v.strip():
return []
return [i.strip() for i in v.split(",")]
elif isinstance(v, list | str):
return v
Expand Down