Skip to content

💚 Fix CI test suite for Windows and MacOS #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 17, 2025
Merged

💚 Fix CI test suite for Windows and MacOS #1307

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6343647
fix test to be ready for Windows
svlandeg Feb 21, 2025
f9465b2
put os into the matrix
svlandeg Feb 21, 2025
adca0b0
test with 3 os's
svlandeg Feb 21, 2025
94d8cf3
Add OS version to coverage file name to avoid duplicates
svlandeg Feb 21, 2025
86ab165
only test on ubuntu
svlandeg Feb 21, 2025
68ee41f
also test on macos-latest
svlandeg Feb 21, 2025
b75acf9
only test on macos-latest
svlandeg Feb 21, 2025
e67f194
user runner.os instead
svlandeg Feb 21, 2025
36595bf
Merge branch 'main' into feat/ci_again
svlandeg Feb 24, 2025
922d5c7
Merge branch 'main' into feat/ci_again
svlandeg Mar 26, 2025
e925c9b
Merge branch 'main' into feat/ci_again
svlandeg Apr 28, 2025
329a737
try on windows only
svlandeg Apr 28, 2025
2e173ea
set relative_files setting to True
svlandeg Apr 28, 2025
bcbc13e
test on all 3 OS's
svlandeg Apr 28, 2025
a7adbb5
Merge branch 'main' into feat/ci_again
svlandeg Apr 28, 2025
e630ce1
avoid exponential explosion of test configurations
svlandeg Apr 28, 2025
cfd2a5e
fix after merge conflict
svlandeg Sep 17, 2025
cecbb4a
Merge branch 'main' into feat/ci_again
svlandeg Sep 17, 2025
efebba6
restore code as is on current main
svlandeg Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
test:
strategy:
matrix:
os: [ ubuntu-latest ]
os: [ ubuntu-latest, windows-latest, macos-latest ]
python-version:
- "3.8"
- "3.9"
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
- name: Store coverage files
uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.python-version }}-${{ matrix.pydantic-version }}
name: coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.pydantic-version }}
path: coverage
include-hidden-files: true

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ source = [
]
context = '${CONTEXT}'
dynamic_context = "test_function"
relative_files = true
Copy link
Member Author

@svlandeg svlandeg Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage test kept on giving this error for either MacOS or Windows:

No source for code: '/Users/runner/work/sqlmodel/sqlmodel/docs_src/__init__.py'.

This is fixed by using the relative_files setting 🎉


[tool.coverage.report]
show_missing = true
Expand Down
4 changes: 2 additions & 2 deletions tests/test_select_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ def test_select_gen() -> None:
env = os.environ.copy()
env["CHECK_JINJA"] = "1"
result = subprocess.run(
[sys.executable, "scripts/generate_select.py"],
env=env,
[sys.executable, Path("scripts") / "generate_select.py"],
env={**os.environ},
check=True,
cwd=root_path,
capture_output=True,
Expand Down
Loading